From owner-svn-src-head@FreeBSD.ORG Wed Feb 4 21:16:59 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 798574BC; Wed, 4 Feb 2015 21:16:59 +0000 (UTC) Received: from tensor.andric.com (unknown [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 19729869; Wed, 4 Feb 2015 21:16:59 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::d66:7769:9ca9:807e] (unknown [IPv6:2001:7b8:3a7:0:d66:7769:9ca9:807e]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 3C4F95C2E; Wed, 4 Feb 2015 22:16:52 +0100 (CET) Subject: Re: svn commit: r278223 - head/lib/clang Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_AB36565E-CDC2-4082-9645-849187671688"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b4 (755500a+) From: Dimitry Andric In-Reply-To: Date: Wed, 4 Feb 2015 22:16:47 +0100 Message-Id: <7338E032-8668-44D2-AE98-C3E50E512DDD@FreeBSD.org> References: <201502042100.t14L0Ued055489@svn.freebsd.org> To: NGie Cooper X-Mailer: Apple Mail (2.2070.6) Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Feb 2015 21:16:59 -0000 --Apple-Mail=_AB36565E-CDC2-4082-9645-849187671688 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 04 Feb 2015, at 22:09, NGie Cooper wrote: > > On Wed, Feb 4, 2015 at 1:00 PM, Dimitry Andric wrote: >> Author: dim >> Date: Wed Feb 4 21:00:29 2015 >> New Revision: 278223 >> URL: https://svnweb.freebsd.org/changeset/base/278223 >> >> Log: >> For now, add -stdlib=libc++ to the flags for building clang, since that >> makes it easier to build head on stable/9, where libstdc++ is still the >> default. We can revisit this when somebody will try to build base with >> gcc 4.8.1 or higher, and its included libstdc++. > > Maybe this should be conditionalized on COMPILER_TYPE? COMPILER_TYPE doesn't say anything about the C++ library used. Maybe we need a CXX_LIBRARY_TYPE setting for it? That said, you may be right that it should be conditionalized on the compiler type anyway, since gcc does not support the -stdlib= option. -Dimitry --Apple-Mail=_AB36565E-CDC2-4082-9645-849187671688 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.26 iEYEARECAAYFAlTSjEIACgkQsF6jCi4glqP4RQCdFNVHO/UigCPBnBQ1kf86e6e7 1PMAn3fWQ0knM5I8iotG4/kQyinHCuP2 =lqhD -----END PGP SIGNATURE----- --Apple-Mail=_AB36565E-CDC2-4082-9645-849187671688--