From owner-cvs-usrbin Thu Oct 31 07:31:39 1996 Return-Path: owner-cvs-usrbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id HAA14617 for cvs-usrbin-outgoing; Thu, 31 Oct 1996 07:31:39 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id HAA14609; Thu, 31 Oct 1996 07:31:32 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.7.6/8.6.9) id CAA03045; Fri, 1 Nov 1996 02:28:43 +1100 Date: Fri, 1 Nov 1996 02:28:43 +1100 From: Bruce Evans Message-Id: <199610311528.CAA03045@godzilla.zeta.org.au> To: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org, phk@freefall.freebsd.org Subject: Re: cvs commit: src/usr.bin/fetch main.c Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Modified: usr.bin/fetch main.c > Log: > bin/1933: don't print negative % for huge files (80Mb) Huge files (size > INT_MAX) are still broken. Humungous files (size > min(LONG_MAX for ftp, LONG_MAX for ftpd) are still broken. ftp reads the restart point using atol(), without any overflow checking of course... ftp_file_op() further limits the restart point to INT_MAX by printing it in %d format. The format doesn't match the arg type of course. Bruce