From owner-svn-src-all@FreeBSD.ORG Thu May 19 21:30:03 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B4D491065670; Thu, 19 May 2011 21:30:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 7D4D48FC1D; Thu, 19 May 2011 21:30:03 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 15DA946B09; Thu, 19 May 2011 17:30:03 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 9CC178A050; Thu, 19 May 2011 17:30:02 -0400 (EDT) From: John Baldwin To: Doug Barton Date: Thu, 19 May 2011 17:30:02 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <201105180214.p4I2EQar056652@svn.freebsd.org> <20110519185554.GA75039@server.vk2pj.dyndns.org> <4DD585EF.1090704@FreeBSD.org> In-Reply-To: <4DD585EF.1090704@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201105191730.02157.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Thu, 19 May 2011 17:30:02 -0400 (EDT) Cc: src-committers@freebsd.org, Peter Jeremy , svn-src-stable@freebsd.org, svn-src-all@freebsd.org, svn-src-stable-8@freebsd.org, Rick Macklem Subject: Re: svn commit: r222048 - stable/8/sys/fs/nfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2011 21:30:04 -0000 On Thursday, May 19, 2011 5:04:47 pm Doug Barton wrote: > On 5/19/2011 11:55 AM, Peter Jeremy wrote: > > On 2011-May-18 02:14:26 +0000, Rick Macklem wrote: > >> Author: rmacklem > >> Date: Wed May 18 02:14:26 2011 > >> New Revision: 222048 > >> URL: http://svn.freebsd.org/changeset/base/222048 > >> > >> Log: > >> MFC: r221462 > >> Add a comment noting that the NFS code assumes that the > >> values of error numbers in sys/errno.h will be the same > >> as the ones specified by the NFS RFCs and that the code > >> needs to be fixed if error numbers are changed in sys/errno.h. > >> > >> Modified: > >> stable/8/sys/fs/nfs/nfsproto.h > >> Directory Properties: > >> stable/8/sys/ (props changed) > >> stable/8/sys/amd64/include/xen/ (props changed) > >> stable/8/sys/cddl/contrib/opensolaris/ (props changed) > >> stable/8/sys/contrib/dev/acpica/ (props changed) > >> stable/8/sys/contrib/pf/ (props changed) > > > > Picking a commit at random, I notice that lots of -stable commits > > include property changes to apparently unrelated parts of the tree. > > Is this intentional? ViewVC doesn't seem to let me view the actual > > properties. > > This happens because people do merges at improper locations in the tree, > then when people come along and do it right (as Rick seems to have done > here) svn helpfully updates the mergeinfo on files/directories that have > it below where it is supposed to be. > > Some of us periodically go through and fix this, but it would be very > helpful if people would stop breaking it. :) No, these are all legitimate (or mostly so). The opensolaris, acpica, and pf nodes all have mergeinfo due to merges from the vendor area. amd64/include/xen is possibly dubious. If we are never going to do a future merge from i386/include/xen to amd64/include/xen then we can just remove that mergeinfo. -- John Baldwin