Date: Wed, 30 Dec 2009 00:55:33 +0100 From: =?ISO-8859-1?Q?Micka=EBl_Maillot?= <mickael.maillot@gmail.com> To: Xin LI <delphij@gmail.com> Cc: freebsd-fs@freebsd.org Subject: Re: ZFS small fix in arc.c and zvol.c Message-ID: <ea7b7b810912291555p621deac4g33aa106405a62177@mail.gmail.com> In-Reply-To: <a78074950912291410jd37101agcc6fc7c974f1829d@mail.gmail.com> References: <ea7b7b810912291246v4a989cd2t357b0a34f99a56e1@mail.gmail.com> <a78074950912291410jd37101agcc6fc7c974f1829d@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
2009/12/29 Xin LI <delphij@gmail.com>: > Hi, > > I think we'd better to bring our base code to be more current rather > than picking up individual revisions, diverging further is probably > not a good idea if we see long term cooperation with OpenSolaris as a > goal... > > On Tue, Dec 29, 2009 at 12:46 PM, Micka=EBl Maillot > <mickael.maillot@gmail.com> wrote: >> Hi, >> >> /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs >> in arc.c, a mutex is not properly detroyed: >> >> --- arc.c.orig =A02009-12-29 21:15:31.192819155 +0100 >> +++ arc.c =A0 =A0 =A0 2009-12-29 21:16:58.034271766 +0100 >> @@ -3626,6 +3626,7 @@ >> =A0 =A0 =A0 =A0mutex_destroy(&arc_mru_ghost->arcs_mtx); >> =A0 =A0 =A0 =A0mutex_destroy(&arc_mfu->arcs_mtx); >> =A0 =A0 =A0 =A0mutex_destroy(&arc_mfu_ghost->arcs_mtx); >> + =A0 =A0 =A0 mutex_destroy(&arc_l2c_only->arcs_mtx); >> >> =A0 =A0 =A0 =A0mutex_destroy(&zfs_write_limit_lock); > > Looks like a part of OpenSolaris onnv revision 8214? =A0Are you having > some specific issue without this patch? > i don't have any problem, it's just look like a miss. only this line is missing. http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=3D6747934 http://hg.intevation.org/mirrors/opensolaris.org/onnv-gate/rev/d7abf7c1f1c1 >> i dont know if it's ok but in zvol.c >> opensolaris call zvol_size_changed >> just after zil_replay in zvol_create_minor function >> >> --- zvol.c.orig 2009-12-29 21:31:42.111529028 +0100 >> +++ zvol.c =A0 =A0 =A02009-12-29 21:32:32.347413297 +0100 >> @@ -837,6 +837,7 @@ >> =A0 =A0 =A0 =A0zv->zv_volblocksize =3D doi.doi_data_block_size; >> >> =A0 =A0 =A0 =A0zil_replay(os, zv, &zv->zv_txg_assign, zvol_replay_vector= , NULL); >> + =A0 =A0 =A0 zvol_size_changed(zv, maj); >> >> =A0 =A0 =A0 =A0/* XXX this should handle the possible i/o error */ >> =A0 =A0 =A0 =A0VERIFY(dsl_prop_register(dmu_objset_ds(zv->zv_objset), > > It seems that the OpenSolaris code has changed a lot and I didn't find > similar change in OpenSolaris (yet). =A0Do you have a specific revision > number or a tag? > > Cheers, > -- > Xin LI <delphij@delphij.net> http://www.delphij.net > i just compare with zvol.c at nov 2008, this line was recently removed with: http://cvs.opensolaris.org/source/diff/onnv/onnv-gate/usr/src/uts/common/fs= /zfs/zvol.c?r2=3D%252Fonnv%252Fonnv-gate%252Fusr%252Fsrc%252Futs%252Fcommon= %252Ffs%252Fzfs%252Fzvol.c%4010588%3Adc03f981ea18&r1=3D%252Fonnv%252Fonnv-g= ate%252Fusr%252Fsrc%252Futs%252Fcommon%252Ffs%252Fzfs%252Fzvol.c%4010310%3A= ba87b3315737 but with comment on r196927 from pjd, may be it's ok to add zvol_size_changed or totally useless.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ea7b7b810912291555p621deac4g33aa106405a62177>