From owner-freebsd-current@FreeBSD.ORG Wed Feb 13 20:22:53 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BBAC916A417; Wed, 13 Feb 2008 20:22:53 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay02.kiev.sovam.com (relay02.kiev.sovam.com [62.64.120.197]) by mx1.freebsd.org (Postfix) with ESMTP id 56C3013C47E; Wed, 13 Feb 2008 20:22:53 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.226] (helo=skuns.kiev.zoral.com.ua) by relay02.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1JPO82-0002z1-UH; Wed, 13 Feb 2008 22:22:52 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by skuns.kiev.zoral.com.ua (8.14.1/8.14.1) with ESMTP id m1DKMNbX003101 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 13 Feb 2008 22:22:23 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m1DKMihL008142; Wed, 13 Feb 2008 22:22:44 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2/Submit) id m1DKMiXv008128; Wed, 13 Feb 2008 22:22:44 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 13 Feb 2008 22:22:43 +0200 From: Kostik Belousov To: John Baldwin Message-ID: <20080213202243.GX57756@deviant.kiev.zoral.com.ua> References: <20080207125252.GC57756@deviant.kiev.zoral.com.ua> <3bbf2fe10802070611v6c7714b5y18bef10d586944c4@mail.gmail.com> <200802131138.27471.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JnIIZV93fkunJ0kw" Content-Disposition: inline In-Reply-To: <200802131138.27471.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.3 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on skuns.kiev.zoral.com.ua X-Scanner-Signature: a96565856d7d777f03ae631b61e05b17 X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2234 [Feb 13 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Method: none X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release Cc: Attilio Rao , freebsd-current@freebsd.org, Marcel Moolenaar , current@freebsd.org Subject: Re: Old LOR between devfs & devfsmount resurfacing? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2008 20:22:53 -0000 --JnIIZV93fkunJ0kw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 13, 2008 at 11:38:27AM -0500, John Baldwin wrote: > On Thursday 07 February 2008 09:11:46 am Attilio Rao wrote: > > 2008/2/7, Kostik Belousov : > > > On Thu, Feb 07, 2008 at 01:21:09PM +0100, Attilio Rao wrote: > > > > 2008/2/7, Kostik Belousov : > > > > > This LOR shall not be ignored globally. When real, it caused the= =20 > easily > > > > > reproducable lockup of the machine. > > > > > > > > > > It would be better to introduce some lockmgr flag to ignore _thi= s_=20 > locking. > > > > > > > > flag to pass where? > > > To the lockmgr itself at the point of aquisition, like > > > lockmgr(&lk, LK_EXCLUSIVE | LK_INTERLOCK | LK_NOWARN,=20 > &interlk, ...); > >=20 > > No, I really want a general WITNESS support for this (as I also think > > that having something more fine grained than BLESSING will break all > > concerns jhb and me are considering now). > > A simple way to do it would mean hard-coding file and line in a > > witness table. While file is ok, line makes trouble so we should find > > an alternative way to do this. Otherwise we can consider skiping > > checks for a whole function, this should be not so difficult to > > achive. > >=20 > > I need to think more about this. >=20 > I think allowing a flag is fine, just as you can specify MTX_QUIET to qui= et=20 > KTR logs in specific mtx_lock() instances. You would specify LK_NOWITNES= S or=20 > some such and have it not do a witness_checkorder() in that case. Exactly what I wanted. --JnIIZV93fkunJ0kw Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEARECAAYFAkezUZMACgkQC3+MBN1Mb4gd5ACfQL4XbdCmfgleU8dnJOtuAu4x MAwAmwZqoXUMU7uwTMe1hkE4oEBcxvh5 =zP3L -----END PGP SIGNATURE----- --JnIIZV93fkunJ0kw--