From nobody Fri Apr 3 19:25:13 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fnTFj33VZz6Z43S for ; Fri, 03 Apr 2026 19:25:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fnTFj2KV5z3FYl for ; Fri, 03 Apr 2026 19:25:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775244313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dBF7FigiQVoy63CII7qZnQgf2RFDrDHEFelGO9kmJoE=; b=oyZIg4IWxiwqobd0JaHXZzrBmtkOtVWzsb2EqnzBRlt4Muv4O1ZD276UUGNod4yL+cwfou VPo+C2gD5Yj0xHkfe39J1EIVKzE6/HARel+LOhaHLuxjWxIXLHxeddrlhG4Nz8DoTOJNeC BzOxwk//Du+Tl8KaO268xM0HLG+Ixs4rUxIBtQf1hv7YEjWzluyPZy9ac8Z942BhrqMaMJ d7lUEaBvuN/KNiTekL+7CjX+wctIIZ6tgIdRUvb74jY/WK//AC+lxRkhdjRjcy03CyknyZ 01rI11HBByHh9UwilT1xeCfygZi5H53OvyWcepXVqL2qYbeBjR2LQ6hc+piW2Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1775244313; a=rsa-sha256; cv=none; b=VOskSj7rLOggLsleoMv0OLvwbkuGbBAxTQJkf1W6/sg8TM2vhPbEu6J276QLFSHKGUWxuX PaDlNly7WSkMZTJTXiKJL9IKMeyfVy3c3ghmkg3NlyXQ72lUzYpApCpQeDFyvGJky70sSk X1cl44iIJ4FvuenB5ofOdq4QgmiFt2JP7/4GIbJ9SiIyoibHrLr1l6lD4IO5fCbrEVpSmb Wzshm2yz0GDoa5tB+DxVeok5aq5u4L3k+vElV5L1HPWd0CExH1YhJ2BvsDqje8lbEM3PAi fVaf3ifdsm99fhXcv3Yxrv9NHpcATVOn9N3+fT3PMQoczM54oFu0E+7P+8ob9A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1775244313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dBF7FigiQVoy63CII7qZnQgf2RFDrDHEFelGO9kmJoE=; b=klRBMaGfQq5DdCWEvvarnEMgOIBd+oIQgognGASlCPuLXYZTVsA0h8vHYDWUQ2dOnBnNwY N2c+2FCSYP6NWjZRqBEdwotfqrwGhuyifgeImyPjSqfUU/i/jcl2MD6hhme00567Fokwqg Ldqmj3Fn/ccETC31BOyJWvZPiO4M/Ytah2Rts6ygLnIWysCoBjwmcHyIhsBEWSiCel248f T3koQLWg6fyWn9dIabPqibMS62+wcuBCChxb9bI1aeOp1++iYxEGTK6wE7WH2nLcjNsmSt yEb71r7MzoQB5nXQduqKvoFBQKO2A7mgDNVXZgnFJoLIeIe5ga1lDd8KQTORPw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fnTFj1NTKz12J2 for ; Fri, 03 Apr 2026 19:25:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 32b80 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 03 Apr 2026 19:25:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 32cc4beb0a8c - main - tcp: retire TF_SENTSYN List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 32cc4beb0a8c3cadc0de4c255ba512fd7b196607 Auto-Submitted: auto-generated Date: Fri, 03 Apr 2026 19:25:13 +0000 Message-Id: <69d01419.32b80.67cd649@gitrepo.freebsd.org> The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=32cc4beb0a8c3cadc0de4c255ba512fd7b196607 commit 32cc4beb0a8c3cadc0de4c255ba512fd7b196607 Author: Michael Tuexen AuthorDate: 2026-04-03 19:22:11 +0000 Commit: Michael Tuexen CommitDate: 2026-04-03 19:22:11 +0000 tcp: retire TF_SENTSYN This TF_-flag is only used in the RACK stack and not really needed. So replace it, since glebius@ needs a TF_ flag and right now all of them are taken. No functional change intended. Reviewed by: rrs, glebius, rscheff, Nick Banks Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D56025 --- sys/netinet/tcp_stacks/rack.c | 4 +--- sys/netinet/tcp_var.h | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index 78b0026a8c5d..2e3fcc7a9762 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -22106,10 +22106,8 @@ out: * Now for special SYN/FIN handling. */ if (flags & (TH_SYN | TH_FIN)) { - if ((flags & TH_SYN) && - ((tp->t_flags & TF_SENTSYN) == 0)) { + if ((flags & TH_SYN) != 0 && tp->snd_max == tp->iss) { tp->snd_max++; - tp->t_flags |= TF_SENTSYN; } if ((flags & TH_FIN) && ((tp->t_flags & TF_SENTFIN) == 0)) { diff --git a/sys/netinet/tcp_var.h b/sys/netinet/tcp_var.h index a3a42b68c26b..95c4e4c52ba0 100644 --- a/sys/netinet/tcp_var.h +++ b/sys/netinet/tcp_var.h @@ -789,7 +789,7 @@ tcp_packets_this_ack(struct tcpcb *tp, tcp_seq ack) #define TF_TSO 0x01000000 /* TSO enabled on this connection */ #define TF_TOE 0x02000000 /* this connection is offloaded */ #define TF_CLOSED 0x04000000 /* close(2) called on socket */ -#define TF_SENTSYN 0x08000000 /* At least one syn has been sent */ +#define TF_UNUSED 0x08000000 /* was TF_SENTSYN */ #define TF_LRD 0x10000000 /* Lost Retransmission Detection */ #define TF_CONGRECOVERY 0x20000000 /* congestion recovery mode */ #define TF_WASCRECOVERY 0x40000000 /* was in congestion recovery */ @@ -803,7 +803,7 @@ tcp_packets_this_ack(struct tcpcb *tp, tcp_seq ack) "\15TF_NOPUSH\16TF_PREVVALID\17TF_WAKESOR\20TF_GPUTINPROG" \ "\21TF_MORETOCOME\22TF_SONOTCONN\23TF_LASTIDLE\24TF_RXWIN0SENT" \ "\25TF_FASTRECOVERY\26TF_WASFRECOVERY\27TF_SIGNATURE\30TF_FORCEDATA" \ - "\31TF_TSO\32TF_TOE\33TF_CLOSED\34TF_SENTSYN" \ + "\31TF_TSO\32TF_TOE\33TF_CLOSED\34TF_UNUSED" \ "\35TF_LRD\36TF_CONGRECOVERY\37TF_WASCRECOVERY\40TF_FASTOPEN" #define IN_FASTRECOVERY(t_flags) (t_flags & TF_FASTRECOVERY)