Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Feb 2015 16:32:48 +0000 (UTC)
From:      John Marino <marino@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r378309 - head/x11-wm/swm
Message-ID:  <201502021632.t12GWmV8059457@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: marino
Date: Mon Feb  2 16:32:47 2015
New Revision: 378309
URL: https://svnweb.freebsd.org/changeset/ports/378309
QAT: https://qat.redports.org/buildarchive/r378309/

Log:
  x11-wm/swm: This is not jobs-safe
  
  The port tries to build the swm executable before the swm.o object file
  is finished building.
  
  While marking this jobs-unsafe, pet portlint so it doesn't complain.  It
  doesn't like "file" being used as a variable name.

Modified:
  head/x11-wm/swm/Makefile

Modified: head/x11-wm/swm/Makefile
==============================================================================
--- head/x11-wm/swm/Makefile	Mon Feb  2 15:43:05 2015	(r378308)
+++ head/x11-wm/swm/Makefile	Mon Feb  2 16:32:47 2015	(r378309)
@@ -34,6 +34,8 @@ SCRIPTS=	startswm
 DATA=		background.xpm closebox.xpm maxbox.xpm stickybox.xpm \
 		swm.colors unstickybox.xpm
 
+MAKE_JOBS_UNSAFE=	yes
+
 post-patch:
 	@${REINPLACE_CMD} -e 's|monotype|fixed|g ; \
 		 s|/usr/share/swm|${DATADIR}|g' ${WRKSRC}/swm.conf
@@ -45,11 +47,11 @@ post-build:
 		*.c -o ${WRKSRC}/swmswitch -lX11 -L${LOCALBASE}/lib
 
 do-install:
-.for file in ${BINS}
-	${INSTALL_PROGRAM} ${WRKSRC}/${file} ${STAGEDIR}${PREFIX}/bin
+.for f in ${BINS}
+	${INSTALL_PROGRAM} ${WRKSRC}/${f} ${STAGEDIR}${PREFIX}/bin
 .endfor
-.for file in ${SCRIPTS}
-	${INSTALL_SCRIPT} ${WRKSRC}/${file} ${STAGEDIR}${PREFIX}/bin
+.for f in ${SCRIPTS}
+	${INSTALL_SCRIPT} ${WRKSRC}/${f} ${STAGEDIR}${PREFIX}/bin
 .endfor
 	${INSTALL_MAN} ${WRKSRC}/swm.1x ${STAGEDIR}${MANPREFIX}/man/man1/swm.1
 	${INSTALL_MAN} ${WRKSRC}/../swmbg/swmbg.1x ${STAGEDIR}${MANPREFIX}/man/man1/swmbg.1



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201502021632.t12GWmV8059457>