Date: Sun, 09 Apr 2017 04:27:18 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Ben Woods <woodsb02@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r429481 - in head: . x11 x11/lightdm x11/lightdm-gtk-greeter x11/lightdm/files Message-ID: <h91y-joxl-wny@FreeBSD.org> In-Reply-To: <20161226072913.0371FFAE@freefall.freebsd.org> (Jan Beich's message of "Mon, 26 Dec 2016 07:29:12 %2B0000 (UTC)") References: <201612260653.uBQ6rbp5054319@repo.freebsd.org> <20161226072913.0371FFAE@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
jbeich@freebsd.org (Jan Beich) writes:
>> --- /dev/null 00:00:00 1970 (empty, because file is newly added)
>> +++ head/x11/lightdm/files/patch-src_process.c Mon Dec 26 06:53:37 2016 (r429481)
>> @@ -0,0 +1,11 @@
>> +--- src/process.c.orig 2016-12-08 21:38:14 UTC
>> ++++ src/process.c
>> +@@ -231,7 +231,7 @@ process_start (Process *process, gboolea
>> + #ifdef HAVE_CLEARENV
>> + clearenv ();
>> + #else
>> +- environ = NULL;
>> ++ putenv ("environ=NULL");
>> + #endif
>> + for (i = 0; i < env_length; i++)
>> + setenv (env_keys[i], env_values[i], TRUE);
>
> Looks bogus, see environ(7). Maybe use "env -i" version:
>
> extern char **environ;
> char *cleanenv[1];
> environ = cleanenv;
> cleanenv[0] = NULL;
Did you ignore this despite possible security implications? I'm not a user,
so just guessing.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?h91y-joxl-wny>