From owner-cvs-all Thu Jan 4 15:40:47 2001 From owner-cvs-all@FreeBSD.ORG Thu Jan 4 15:40:44 2001 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mailgate.originative.co.uk (mailgate.originative.co.uk [62.232.68.68]) by hub.freebsd.org (Postfix) with ESMTP id 53C8437B400; Thu, 4 Jan 2001 15:40:44 -0800 (PST) Received: from originative.co.uk (tiddler.originative.co.uk [62.232.68.83]) by mailgate.originative.co.uk (Postfix) with ESMTP id AF70E1D140; Thu, 4 Jan 2001 23:40:38 +0000 (GMT) Sender: paul@originative.co.uk Message-ID: <3A550A97.C7789A6C@originative.co.uk> Date: Thu, 04 Jan 2001 23:43:19 +0000 From: Paul Richards X-Mailer: Mozilla 4.75 [en] (X11; U; Linux 2.2.12 i386) X-Accept-Language: en MIME-Version: 1.0 To: Tony Finch Cc: Paul Richards , Dag-Erling Smorgrav , Mark Murray , Paul Richards , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/update pkg_update.pl References: <200101041509.f04F9kY06526@gratis.grondar.za> <3A54A329.3A84087F@freebsd-services.co.uk> <20010104214946.W2140@hand.dotat.at> <3A54F477.DCD11D4B@originative.co.uk> <20010104224743.Z2140@hand.dotat.at> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Tony Finch wrote: > > Paul Richards wrote: > > > >The mistake was using "<$file", what I should have done was use the list > >version i.e. > > > >open(HANDLE, "<", $file) > > That must require perl 5.6 because it doesn't work in 5.005. Yes it does, maybe not such a generic solution then but probably the correct way to code things in the future. In any case, this thread is a bit of a red herring, the fix I applied of "< $file" is a correct fix for the bug though it is not as safe as it could be since $file does need some taint checking. Paul. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message