From owner-freebsd-net@FreeBSD.ORG Sat Jul 19 02:44:00 2014 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C477A1D7; Sat, 19 Jul 2014 02:44:00 +0000 (UTC) Received: from mail-pd0-x22f.google.com (mail-pd0-x22f.google.com [IPv6:2607:f8b0:400e:c02::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8682E2B15; Sat, 19 Jul 2014 02:44:00 +0000 (UTC) Received: by mail-pd0-f175.google.com with SMTP id r10so4514753pdi.20 for ; Fri, 18 Jul 2014 19:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=Sv3LLxcITLr/WH3IY8GYApG2HrC7OWCauaIhWaAOcJk=; b=0cMSWx92kOv4V6VJwkDdGhDfjOsR+FESJ+PKnSe/pIrMjzLu57PdfSgtO7v1XU/Nlt o7PxS1sD/a8hUOednq5bpw8SOoe765eNmZHRXIXGYpuKWiXCGjm4BkeRoiNV73l6ASQe Iuhu2ObM13xJAnx+2PuYxUu8EAfocnP3v+FqE3tau+W2s5rlH2X+4ecv2NZfyeCoHjkz gyZiUAdugHMUe0bnId6OTIjSruJClIxumH6tGtUnFy3GbHMSM5LfgRsBxRpDWsDdFfHE 8x82o4YZT8QRGzeGVKBOwq1x1OrbVG0DNm4kBn3xMA6t7B6++CBZ76kwn4rQodBmLIam cvjg== X-Received: by 10.68.136.226 with SMTP id qd2mr9759318pbb.72.1405737840010; Fri, 18 Jul 2014 19:44:00 -0700 (PDT) Received: from [10.192.166.0] (stargate.chelsio.com. [67.207.112.58]) by mx.google.com with ESMTPSA id kt2sm6953199pbc.83.2014.07.18.19.43.59 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 18 Jul 2014 19:43:59 -0700 (PDT) Message-ID: <53C9DB6E.8040205@gmail.com> Date: Fri, 18 Jul 2014 19:43:58 -0700 From: Navdeep Parhar User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: araujo@FreeBSD.org Subject: Re: [patch][lagg] - Set a better granularity and distribution on roundrobin protocol. References: <53C964F7.8060503@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: FreeBSD Net , Adrian Chadd X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jul 2014 02:44:00 -0000 On 07/18/14 19:06, Marcelo Araujo wrote: > > > > 2014-07-19 2:18 GMT+08:00 Navdeep Parhar >: > > On 07/18/14 00:49, Marcelo Araujo wrote: > > Hello guys, > > > > I made few changes on the lagg(4) patch. Also, I made tests using > igb(4), > > ixgbe(4) and em(4); seems everything worked pretty well. > > > > I'm wondering if anyone else could make a review, and what I need > to do, to > > see this patch committed. > > Deliberately putting out-of-order packets on the wire is never a good > idea. This would count as a serious regression in lagg(4) imho. > > Regards, > Navdeep > > > > I'm wondering if anyone have tested the patch; because as I have > explained in another email, the number of SACK is much less with this > patch. I have put some pcap files > here: http://people.freebsd.org/~araujo/lagg/ > > Also, as far as I know, the current roundrobin implementation has no > such kind of mechanism to control the order of the packages that goes to > the wire. And this patch, what it only does is, instead to send only one > package through one interface and switch to the another one, it will > send X(where X is the number of packets defined via sysctl) packets and > then, switch to the next interface. > > So, could you show me, where this patch deliberately put out-of-order > packets? Did I miss anything? Are you saying lagg's roundrobin implementation is already spraying packets for the same flow across interfaces? That would make it unsuitable for anything TCP. But then your patch isn't making it any worse so I don't have any objection to it any more. Looks like loadbalance does the right thing for flows. Regards, Navdeep