From owner-svn-src-all@freebsd.org Wed Jul 31 19:43:08 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2887FA6EC9; Wed, 31 Jul 2019 19:43:08 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 45zP3b36Zlz4FtT; Wed, 31 Jul 2019 19:43:06 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x6VJgqjU024303 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 31 Jul 2019 22:42:55 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x6VJgqjU024303 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x6VJgqpT024302; Wed, 31 Jul 2019 22:42:52 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 31 Jul 2019 22:42:52 +0300 From: Konstantin Belousov To: Bryan Drewery Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r350005 - head/sys/kern Message-ID: <20190731194252.GO2731@kib.kiev.ua> References: <201907151918.x6FJIPFo077975@repo.freebsd.org> <20190730231256.GL2731@kib.kiev.ua> <20190730232714.GM2731@kib.kiev.ua> <5d3ffe05-58f3-ea26-13ed-51cdcd1deeaa@FreeBSD.org> <20190731051452.GN2731@kib.kiev.ua> <46c7a7bc-29ec-6176-0ede-96ac91984589@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46c7a7bc-29ec-6176-0ede-96ac91984589@FreeBSD.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jul 2019 19:43:08 -0000 On Wed, Jul 31, 2019 at 10:08:39AM -0700, Bryan Drewery wrote: > On 7/30/19 10:14 PM, Konstantin Belousov wrote: > > No, you should create a situation where the python process ends the endless > > loop, as reported. Then, it should become killable by 9 with the first > > chunk only applied. > > > > I don't have an easy way to test that. kill -9 inside the loop didn't > work. Once the loop ended the process was done; it is very short lived > and the calling code is buried in Python I think. With only the umtxq_check_susp() chunk applied, you would wait for python to start looping, then verify that kill -9 works. Anyway, I believe that the change is correct, and put the review at https://reviews.freebsd.org/D21124. I will commit after it get some sanity checking by mentioned people.