From owner-freebsd-scsi Tue Aug 13 4:11:15 2002 Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1748C37B400; Tue, 13 Aug 2002 04:11:13 -0700 (PDT) Received: from ns.sanda.gr.jp (ns.sanda.gr.jp [210.232.122.18]) by mx1.FreeBSD.org (Postfix) with ESMTP id A828543E4A; Tue, 13 Aug 2002 04:11:11 -0700 (PDT) (envelope-from non@ever.sanda.gr.jp) Received: from ever.sanda.gr.jp (epoch [10.93.63.51]) by ns.sanda.gr.jp (8.11.6/3.7W) with ESMTP id g7DBBAa78553; Tue, 13 Aug 2002 20:11:10 +0900 (JST) Received: from localhost (localhost [127.0.0.1]) by ever.sanda.gr.jp (8.8.8/3.3W9) with ESMTP id UAA06664; Tue, 13 Aug 2002 20:11:09 +0900 (JST) To: scsi@FreeBSD.org Cc: non@FreeBSD.org Subject: Re: Review In-Reply-To: <184350000.1029208017@aslan.scsiguy.com> References: <20020812.163013.28786716.imp@bsdimp.com> <184350000.1029208017@aslan.scsiguy.com> X-Mailer: Mew version 1.94 on Emacs 19.28 / Mule 2.3 =?iso-2022-jp?B?KBskQkt2RSYyVhsoQik=?= Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20020813201109H.non@ever.sanda.gr.jp> Date: Tue, 13 Aug 2002 20:11:09 +0900 From: non@ever.sanda.gr.jp X-Dispatcher: imput version 20000228(IM140) Lines: 16 Sender: owner-freebsd-scsi@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org From: "Justin T. Gibbs" Date: Mon, 12 Aug 2002 21:06:57 -0600 > > panic already terminates messages with \n. There are a few in cam > > that redundantly include the \n. Here's a small patch to remove > > them. Any objections to my committing it? I checked the NetBSD's syssrc/sys/lib/libsa/panic.c and found that it also adds \n . > My only concern is with the scsi_low.c change in that it may diverge > us from NetBSD. I don't know that there is going to be much change in > this code any time soon, so that may not be an issue. I will E-mail to the orignal author. So please go ahead. // Noriaki Mitsunaga // To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message