From owner-freebsd-net@FreeBSD.ORG  Tue Jul 15 10:00:54 2014
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 35DF0CD5;
 Tue, 15 Jul 2014 10:00:54 +0000 (UTC)
Received: from cu01176b.smtpx.saremail.com (cu01176b.smtpx.saremail.com
 [195.16.151.151])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id DE10423BE;
 Tue, 15 Jul 2014 10:00:53 +0000 (UTC)
Received: from [172.16.2.2] (izaro.sarenet.es [192.148.167.11])
 by proxypop04.sare.net (Postfix) with ESMTPSA id 2AFC59DCE0A;
 Tue, 15 Jul 2014 12:00:51 +0200 (CEST)
Subject: Re: Fix Emulex "oce" driver in CURRENT
Mime-Version: 1.0 (Apple Message framework v1283)
Content-Type: text/plain; charset=us-ascii
From: Borja Marcos <borjam@sarenet.es>
In-Reply-To: <CAO0mX5b4txBAvnjFEJPFgzvraOxY=YKH-HYQnf8B-OVPk3yZHA@mail.gmail.com>
Date: Tue, 15 Jul 2014 12:00:49 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <FB5130A7-B9CF-4CB0-BD21-94637C1B608F@sarenet.es>
References: <CA+hQ2+imE=+ncZwpHGhWb175mYiAKV78MV=Dfc1GJf=3XYciPQ@mail.gmail.com>
 <453BA9EC-BB63-4258-8141-847F41315E1E@sarenet.es>
 <CA+hQ2+jaP2fuMaCoorLpGu=uWDPgHy3at5UdtLAOXM2d6uoWkg@mail.gmail.com>
 <6C8CF68D-68E2-4168-AA0A-6A629D363371@sarenet.es>
 <CAO0mX5bmXnQGuEgSYoBxy8bQK5i3B2MG0LBmJ7A178W1B5sqDw@mail.gmail.com>
 <EAE3F867-D084-43EC-962B-3F2EB5782C68@sarenet.es>
 <CAO0mX5Ys+raCwaQT0eB6jBFWGGAJ6kStsWPRVKOkfNdsP=17Kg@mail.gmail.com>
 <B8458978-1ACC-4083-B29C-E1DFFCFCA3EA@sarenet.es>
 <CAO0mX5a=VWG_bRhvpL3WCZjvbVRMY2hfgfRLc8qHAtVKO3=-2w@mail.gmail.com>
 <CAO0mX5b4txBAvnjFEJPFgzvraOxY=YKH-HYQnf8B-OVPk3yZHA@mail.gmail.com>
To: Stefano Garzarella <stefanogarzarella@gmail.com>
X-Mailer: Apple Mail (2.1283)
Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>,
 freebsd-current <freebsd-current@freebsd.org>,
 Luigi Rizzo <rizzo@iet.unipi.it>, Xin LI <d@delphij.net>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Jul 2014 10:00:54 -0000


On Jul 15, 2014, at 11:45 AM, Stefano Garzarella wrote:

> I just tried to run iperf3 with this patch and STABLE-10 and it seems =
to
> work.
> Do you have a panic?

So far, so good. I've ran a couple of iperf3 tests (60 seconds, trying =
both directions) and it doesn't crash.

Without the fixes I obtained a panic quite reliably, in less than 30 =
seconds.

Still trying. But the bugs you mentioned (lack of locking and =
deallocating, etc) seem to be consistent with the kind of failures I saw =
and their apparent randomness.

So, asking for spiritual counsel now. Would you use this driver  in a =
production environment instead of the 747 version downloaded from =
Emulex? I think the latter is giving slightly better performance but, =
anyway, I disable LRO and TSO because I see a horrible impact on NFS =
performance.

Cheers,





Borja.