From owner-freebsd-bugs@FreeBSD.ORG Wed Nov 29 11:50:20 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 345EE16A40F for ; Wed, 29 Nov 2006 11:50:20 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6800E43CA8 for ; Wed, 29 Nov 2006 11:50:18 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id kATBoJMX018989 for ; Wed, 29 Nov 2006 11:50:19 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id kATBoJaR018988; Wed, 29 Nov 2006 11:50:19 GMT (envelope-from gnats) Resent-Date: Wed, 29 Nov 2006 11:50:19 GMT Resent-Message-Id: <200611291150.kATBoJaR018988@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dennis Yusupoff Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 42CE216A407 for ; Wed, 29 Nov 2006 11:46:49 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [69.147.83.33]) by mx1.FreeBSD.org (Postfix) with ESMTP id BAD4343C9D for ; Wed, 29 Nov 2006 11:46:47 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id kATBkmkN036687 for ; Wed, 29 Nov 2006 11:46:48 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id kATBkmMN036686; Wed, 29 Nov 2006 11:46:48 GMT (envelope-from nobody) Message-Id: <200611291146.kATBkmMN036686@www.freebsd.org> Date: Wed, 29 Nov 2006 11:46:48 GMT From: Dennis Yusupoff To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.0 Cc: Subject: conf/106009: Fix pppoed startup script to process multiply interfaces X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2006 11:50:20 -0000 >Number: 106009 >Category: conf >Synopsis: Fix pppoed startup script to process multiply interfaces >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Nov 29 11:50:18 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Dennis Yusupoff >Release: 6.1-RELEASE-p10 >Organization: Ozerki.net ISP >Environment: FreeBSD nas4.ozerki.net 6.1-STABLE FreeBSD 6.1-STABLE #0: Tue Jul 4 14:11:56 MSD 2006 root@nas4.ozerki.net:/usr/obj/usr/src/sys/NAS4 i386 >Description: By default, startup script /etc/rc.d/pppoed can not handle starting pppoed daemon at some interfaces. It's a pity and important, that's why we fix this script as writen below >How-To-Repeat: /etc/rc.d/pppoed start, then you have more than one interface in /etc/rc.conf string "pppoed_interface="xxx" " >Fix: === #!/bin/sh # # $FreeBSD: src/etc/rc.d/pppoed,v 1.3 2004/10/07 13:55:26 mtm Exp $ # # PROVIDE: pppoed # REQUIRE: NETWORKING # BEFORE: DAEMON # KEYWORD: nojail # Evseev/EBCEEB: pppoe_interface can contain multiple values . /etc/rc.subr name="pppoed" rcvar="`set_rcvar`" start_cmd="pppoed_start" # XXX stop_cmd will not be straightforward stop_cmd=":" pppoed_start() { if [ -n "${pppoed_provider}" ]; then pppoed_flags="${pppoed_flags} -p ${pppoed_provider}" fi echo 'Starting pppoed' _opts=$-; set -f for iface in ${pppoed_interface}; do /usr/libexec/pppoed ${pppoed_flags} $iface done set +f; set -${_opts} } load_rc_config $name run_rc_command "$1" === or diff: nas4# diff -ua /etc/rc.d.OFF/pppoed /etc/rc.d/pppoed --- /etc/rc.d.OFF/pppoed Sun May 8 11:05:12 2005 +++ /etc/rc.d/pppoed Thu Jul 27 14:41:07 2006 @@ -1,6 +1,6 @@ #!/bin/sh # -# $FreeBSD: src/etc/rc.d/pppoed,v 1.2.2.1 2004/10/10 09:50:54 mtm Exp $ +# $FreeBSD: src/etc/rc.d/pppoed,v 1.3 2004/10/07 13:55:26 mtm Exp $ # # PROVIDE: pppoed @@ -8,6 +8,8 @@ # BEFORE: DAEMON # KEYWORD: nojail +# Evseev/EBCEEB: pppoe_interface can contain multiple values + . /etc/rc.subr name="pppoed" @@ -23,7 +25,9 @@ fi echo 'Starting pppoed' _opts=$-; set -f - /usr/libexec/pppoed ${pppoed_flags} ${pppoed_interface} + for iface in ${pppoed_interface}; do + /usr/libexec/pppoed ${pppoed_flags} $iface + done set +f; set -${_opts} } === >Release-Note: >Audit-Trail: >Unformatted: