From nobody Mon Jul 31 07:47:52 2023 X-Original-To: dev-commits-ports-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RDr2L06BCz4pvBv; Mon, 31 Jul 2023 07:48:06 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X448 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RDr2D2JDnz3PdW; Mon, 31 Jul 2023 07:48:04 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Authentication-Results: mx1.freebsd.org; none Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id 653A01630A9; Mon, 31 Jul 2023 09:47:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=anongoth.pl; s=ANONGOTH; t=1690789673; bh=2CC6ArLm9O+jGQ/ZOp3GxIzCpCEOCKcXFZFa22+1b9I=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=OFkzqDpMGTZcUS0Q01Xm6p8mSyLTTmuao0Jq4BqZWcOHrw1+OKySEydJ1xI5hgHlh dM4Z+7WWes7zy8o1sUl88A6BxgLQ+2MB2QxHt1xYvkT2DUTo44trccX2wLgjShZ1Rb PkfmIRHhc6k3RirntPc9JyBAsHgx7gLJAsH11wrHcUIFfsOOvd00LSAnpVrMm4fv78 ZZcLuSQwg0cP+9jNHmqSpKOw+UHCAsCpxzmLWUFiVwA//JMp94qdVebTllo/myYo7U sE8ROyHrglcojlW0DvLYmts/LMKf/3YA7100lzOft17nJ2EBPbTMuVNC6Sg0Fb4wdV yaIKRdJRr0rIQ== Date: Mon, 31 Jul 2023 09:47:52 +0200 From: Piotr Kubaj To: Robert Clausecker Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-branches@freebsd.org Subject: Re: git: 3af2e89732ee - 2023Q3 - graphics/gegl: fix build on armv7 Message-ID: References: <202307302302.36UN2Bdi018404@gitrepo.freebsd.org> List-Id: Commits to the quarterly branches of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-branches@freebsd.org X-BeenThere: dev-commits-ports-branches@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EhQk4fv1jV/ZwbBE" Content-Disposition: inline In-Reply-To: <202307302302.36UN2Bdi018404@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4RDr2D2JDnz3PdW X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:47544, ipnet:46.248.160.0/19, country:PL] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated --EhQk4fv1jV/ZwbBE Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Wouldn't it be better to do it similarly to other ports? =2Eif !exists(/usr/include/omp.h) MESON_ARGS+=3D -Dopenmp=3Ddisabled =2Eendif This would also fix build on other OpenMP-less architectures and if a user = on OpenMP-enabled architecture decides to build base with libomp. On 23-07-30 23:02:11, Robert Clausecker wrote: > The branch 2023Q3 has been updated by fuz: >=20 > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D3af2e89732ee15c2b8c39e8e= c5a0f97ebc66635d >=20 > commit 3af2e89732ee15c2b8c39e8ec5a0f97ebc66635d > Author: Robert Clausecker > AuthorDate: 2023-07-28 21:01:02 +0000 > Commit: Robert Clausecker > CommitDate: 2023-07-30 23:01:42 +0000 >=20 > graphics/gegl: fix build on armv7 > =20 > OpenMP is not supported on armv7. Fix the build by disabling its use. > =20 > Approved by: portmgr (build fix blanket) > MFH: 2023Q3 > =20 > (cherry picked from commit 9e2602394b77661efe58bb191416048e3ca7c7c7) > --- > graphics/gegl/Makefile | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/graphics/gegl/Makefile b/graphics/gegl/Makefile > index 6fbbd2446c43..9e1784ebd599 100644 > --- a/graphics/gegl/Makefile > +++ b/graphics/gegl/Makefile > @@ -33,7 +33,10 @@ MESON_ARGS=3D -Ddocs=3Dfalse \ > -Dmaxflow=3Ddisabled \ > -Dmrg=3Ddisabled \ > -Dpygobject=3Ddisabled \ > - -Dlua=3Ddisabled > + -Dlua=3Ddisabled \ > + ${MESON_ARGS_${ARCH}} > +MESON_ARGS_armv6=3D -Dopenmp=3Ddisabled > +MESON_ARGS_armv7=3D -Dopenmp=3Ddisabled > =20 > GEGL_SHLIB=3D 0.443.1 > GEGL_VER=3D 0.4 --EhQk4fv1jV/ZwbBE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmTHZygACgkQelmbhSCD nJ3J6w//QWZnz51eGvyoTlJivhA6Xt0TZ84GyUL2Sh1fx4aSoy93h/u93Il4HvaF LkilEUuYEVHnctv4dvBCZjGeTj9bt5YrO7Pzj1ct6KrLvWasYkSOZSKJbMeMB+iw n5qDF6lLI94sJnUz2owTNBI+niHvUukSzNy5YY/GWys/K5EZFAkhHtwVW4Vpw7hW vRuV2HMvbBKfLJUJw5OFYgaYXG55+4UKIzwAVznL8DOrxJ6Rtc2X+vTn2obuA9Kp RpJ9UAmYlsSLJe2C69ekxXQC2P9m1IHrx6QFqR11OBmx3Rt2ZPQch2Sw338gQAgc D/Oqhl6cwCQ7l41aJy4Ib0MZ3Ud8Qvq51N8MoJYHFPOn4Zfi5JIHnmTOHW9x7XLP h7N1SjBGSsM1PFkQMq6l/lfkC5z1GFc2uYov60rU6o44wmHh39McMWCFGELGIuYY 7qEcE2q80whIE0lVH6e6h9ZbMqUlNQ2uLt4AYRWj4bqqpnmAEgPQezTp42wRlieE mrgPquiIfSGmZKc4Rx2p7PvpPpKifkLljrhL07BFz0JyLiMhDYbCOT6pwd0CCLkk RWFEICx1uEz2j3MLMQjWdm+87TCRkDxtoAeRfD4A3t3EXJCg9SJra91mYoJGNWbR F5zlp8kxHZA14ZHJCrSK2XBRpht6rEgzaEZLlWIZ62lF7VrDEVk= =DIsK -----END PGP SIGNATURE----- --EhQk4fv1jV/ZwbBE--