From nobody Thu Mar 28 19:36:51 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V5DLr4QD3z5Frlr for ; Thu, 28 Mar 2024 19:36:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V5DLr3Pxgz4TD1 for ; Thu, 28 Mar 2024 19:36:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711654612; a=rsa-sha256; cv=none; b=MuycQbQmZtbRnnJpPV538K2cwUmA4n5rO+piEOMji9XPFOC1dE/eKhehHcBoW4aBuEVKMB 2MWlZq7LN0d36O3Ha+BEGgh48Ga/lQRdBe+9pjHQDsNkZ6mpgYRs5C9kZehRLCF1Cpobfg f1svLdqa3TG0vhTooB43GgxDEKPq461OlOwIgXSgOAa2Fa8WOlx/aN8Tgh1CBmeeudNEEB o8crPy9jmhFfj4nm+Xobl6TQhtcTQJ/5k4Dcudf3MAHetA/mdZDnvdBg7a2OTWUh5iU7k9 eI55+R2xAcuqh5kMg6uHQWwK5m7VsxCss0W3i4emdJSMTC9eyHggDuqgC69Y2w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711654612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9NoBWieG2Ba4qQxMruRIQgMEDIROyief1mmY+4RdIU8=; b=CqqBTQ1YcWgFZc/MSY3K4OlFxtpOw/3pSBeUTvwhv9uLv9Ff+cyebQz+xCPkGpRKPCMeuB UBFl6EBBx1XtcTCKzGrrIu+6CstZXfcKhUkZsWxppeAXuud3JLRzUZoT6qca7h0fHI1Gvt dI8AA4pU79+LYdgjwC8xR0W0osZrHemi8QKh+BJGcfibejDr+kvWf2hCJj0Ie1Yxebys+v zg0y9ZlXHHNi8f6bM5ImZaulBH2iF2bo39DThvWN37Ia3uNPWeEbRYQ8pxp3qVjGqwzHGW PGVmIchPGyxTNSr1bjDWeKEjiSv7r7CiHgDAr2/FLcr8f9XPwS1hEQ5zpZWEuA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4V5DLr32Q2zgTs for ; Thu, 28 Mar 2024 19:36:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 42SJaq0t042508 for ; Thu, 28 Mar 2024 19:36:52 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 42SJaqti042506 for net@FreeBSD.org; Thu, 28 Mar 2024 19:36:52 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 277349] The net.inet.ip.source_address_validation should ignore CARP IP in backup state Date: Thu, 28 Mar 2024 19:36:51 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277349 --- Comment #10 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dd6e1ae659b11a13a9c289424735394173= 907c1d3 commit d6e1ae659b11a13a9c289424735394173907c1d3 Author: Gleb Smirnoff AuthorDate: 2024-03-19 18:48:59 +0000 Commit: Gleb Smirnoff CommitDate: 2024-03-28 19:35:45 +0000 carp: check CARP status in in_localip_fib(), in6_localip_fib() Don't report a BACKUP CARP address as local. These two functions are u= sed only by source address validation for input packets, controlled by sysc= tls net.inet.ip.source_address_validation and net.inet6.ip6.source_address_validation. For this purpose we definitely want to treat BACKUP addresses as non local. This change is conservative and doesn't modify compat in_localip() and in6_localip(). They are used more widely than the FIB-aware versions. The change would modify the notion of ipfw(4) 'me' keyword. There might be other consequences as in_localip() is used by various tunneling protocols. PR: 277349 (cherry picked from commit 56f7860087eec14b4a65310b70bd704e79e1b48c) sys/netinet/in.c | 4 +++- sys/netinet6/in6.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=