From owner-freebsd-current Fri Jun 7 23:27: 4 2002 Delivered-To: freebsd-current@freebsd.org Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by hub.freebsd.org (Postfix) with ESMTP id F23CF37B401; Fri, 7 Jun 2002 23:26:57 -0700 (PDT) Received: from odin.ac.hmc.edu (IDENT:brdavis@localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.12.3/8.12.3) with ESMTP id g586QuM3001958; Fri, 7 Jun 2002 23:26:56 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.12.3/8.12.3/Submit) id g586Qu05001957; Fri, 7 Jun 2002 23:26:56 -0700 Date: Fri, 7 Jun 2002 23:26:56 -0700 From: Brooks Davis To: Bruce Evans Cc: Brooks Davis , "David O'Brien" , current@FreeBSD.org, phk@FreeBSD.org Subject: Re: dump (via amanda) causing panics Message-ID: <20020607232656.B1469@Odin.AC.HMC.Edu> References: <20020607150716.A19826@Odin.AC.HMC.Edu> <20020608143938.M18304-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="i0/AhcQY5QxfSsSZ" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20020608143938.M18304-100000@gamplex.bde.org>; from bde@zeta.org.au on Sat, Jun 08, 2002 at 02:45:06PM +1000 X-Virus-Scanned: by amavisd-milter (http://amavis.org/) on odin.ac.hmc.edu Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --i0/AhcQY5QxfSsSZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 08, 2002 at 02:45:06PM +1000, Bruce Evans wrote: > On Fri, 7 Jun 2002, Brooks Davis wrote: >=20 > > On Fri, Jun 07, 2002 at 02:16:45PM -0700, Brooks Davis wrote: > > > On Fri, Jun 07, 2002 at 01:30:37PM -0700, David O'Brien wrote: > > > > On Fri, Jun 07, 2002 at 12:59:55PM -0700, Brooks Davis wrote: > > > > > Applying phk's patch seems to have fixed it. It's a bit overkill= for > > > > > fixing dump, but it did work and I guess this way I can do some l= imited > > > > > testing of the ufs2 patch. >=20 > Is that the full ufs2 patch? phk also committed a quick fix for dump. That's with the full ufs2 patch. > > Here's a sample of the errors I'm seeing: > > > > DUMP: read error from /dev/ad0s2f: Invalid argument: [sector -1980991= 191]: count=3D-1 > > DUMP: read error from /dev/ad0s2f: Invalid argument: [sector -1980991= 190]: count=3D-1 > > ... >=20 > I saw similarly bogus sector (block) numbers when I first debugged this > problem. They were caused by missing prototypes. 32-bit block numbers > were passed to unprototyped functions that expected daddr_t block numbers. > When daddr_t was changed to 64 bits, there was garbage in the top 32 bits. >=20 > dump doesn't compile cleanly at a high WARNS level, so now would be a good > time to WARNSify it. That sounds like a good idea. If someone else doesn't get there first, I'll take a look at that soon. If nothing else, there's the plane trip down to SFO for USENIX. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --i0/AhcQY5QxfSsSZ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE9AaOvXY6L6fI4GtQRAlexAKC3uTuPS0JcZkhFQE6hCv8B19tLMgCcCp22 G/SVUGxxYDLNruX4syirV5s= =kbV4 -----END PGP SIGNATURE----- --i0/AhcQY5QxfSsSZ-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message