From owner-freebsd-acpi@FreeBSD.ORG Fri Jun 12 21:48:01 2009 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1B24B106566C for ; Fri, 12 Jun 2009 21:48:01 +0000 (UTC) (envelope-from nate@root.org) Received: from nlpi157.prodigy.net (nlpi157.sbcis.sbc.com [207.115.36.171]) by mx1.freebsd.org (Postfix) with ESMTP id D48AD8FC08 for ; Fri, 12 Jun 2009 21:48:00 +0000 (UTC) (envelope-from nate@root.org) Received: from [10.0.5.18] (ppp-71-139-2-171.dsl.snfc21.pacbell.net [71.139.2.171]) (authenticated bits=0) by nlpi157.prodigy.net (8.13.8 smtpauth/dk/map_regex/8.13.8) with ESMTP id n5CLZqI9015669; Fri, 12 Jun 2009 16:35:53 -0500 Message-ID: <4A32CA38.4020806@root.org> Date: Fri, 12 Jun 2009 14:35:52 -0700 From: Nate Lawson User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Eygene Ryabinkin References: In-Reply-To: X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-acpi@freebsd.org Subject: Re: [PATCH] acpidump: teach to disassemble arbitrary memory locations as AML code X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2009 21:48:01 -0000 Eygene Ryabinkin wrote: > It is not uncommon when some chunks of the AML code are loaded by DSDT > from the memory locations that aren't part of the DSDT itself, but one > wants to see what's inside. It can be achieved with 'dd' and 'iasl', > but it is better to implement this machinery inside acpidump to ease the > life of both users and develepers that needs to see the full picture > of the ACPI stuff from foreign machines. > > This commit also have some small fixes: > > - verbose output (going to stderr) isn't mixed with normal output > that goes to stdout -- the latter is made unbuffered; > > - we're using IASL's logics to get the name of the output file and, > moreover, we prevent two simultaneous invocations of acpidump > to hose other's output; > > - IASL exit code is checked and if disassembler exited abnormally > or was failed to do its job, the warning is produced to give > the reader an idea on what's going on. > > Signed-off-by: Eygene Ryabinkin I appreciate your work. What we need to do though is remove acpidump(8) from the system and import Intel's acpidmp utility. It's included in the ACPI-CA distribution and is functional enough that we can use it. Any functions we need that it doesn't yet have can be submitted to Intel to merge. Thanks, -- Nate