Date: Tue, 30 Dec 2014 19:48:03 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 195451] [NEW PORT] databases/arangodb - ArangoDB is a multi-purpose, open-source database Message-ID: <bug-195451-13-zo19E2TNUh@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-195451-13@https.bugs.freebsd.org/bugzilla/> References: <bug-195451-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195451 Pawel Pekala <pawel@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pawel@FreeBSD.org --- Comment #1 from Pawel Pekala <pawel@FreeBSD.org> --- For future reference: new ports should be submitted in shar format and changes for UIDs, GIDs files as a svn diff patch. Few ideas for improvements: +COMMENT= ArangoDB the multi-purpose NoSQL DB Please don't use port name in COMMENT, this "recursive" style does not look good later in pkg(8) outputs. +BUILD_DEPENDS= ${LOCALBASE}/bin/python:${PORTSDIR}/lang/python \ This is declared later in USES=python:2, no need for it here. >From Uses/python.mk: # If build and run are omitted, Python will be added as BUILD_DEPENDS and # RUN_DEPENDS. +HAS_CONFIGURE= yes Port uses autotools generated configure so GNU_CONFIGURE=yes here. +post-install: + ${MV} ${STAGEDIR}${PREFIX}/etc/arangodb/arango-dfdb.conf \ + ${STAGEDIR}${PREFIX}/etc/arangodb/arango-dfdb.conf.sample + ${MV} ${STAGEDIR}${PREFIX}/etc/arangodb/arangob.conf \ + ${STAGEDIR}${PREFIX}/etc/arangodb/arangob.conf.sample + ${MV} ${STAGEDIR}${PREFIX}/etc/arangodb/arangod.conf \ + ${STAGEDIR}${PREFIX}/etc/arangodb/arangod.conf.sample + ${MV} ${STAGEDIR}${PREFIX}/etc/arangodb/arangodump.conf \ + ${STAGEDIR}${PREFIX}/etc/arangodb/arangodump.conf.sample + ${MV} ${STAGEDIR}${PREFIX}/etc/arangodb/arangoimp.conf \ + ${STAGEDIR}${PREFIX}/etc/arangodb/arangoimp.conf.sample + ${MV} ${STAGEDIR}${PREFIX}/etc/arangodb/arangoirb.conf \ + ${STAGEDIR}${PREFIX}/etc/arangodb/arangoirb.conf.sample + ${MV} ${STAGEDIR}${PREFIX}/etc/arangodb/arangorestore.conf \ + ${STAGEDIR}${PREFIX}/etc/arangodb/arangorestore.conf.sample + ${MV} ${STAGEDIR}${PREFIX}/etc/arangodb/arangosh.conf \ + ${STAGEDIR}${PREFIX}/etc/arangodb/arangosh.conf.sample + ${MV} ${STAGEDIR}${PREFIX}/etc/arangodb/foxx-manager.conf \ + ${STAGEDIR}${PREFIX}/etc/arangodb/foxx-manager.conf.sample This is way too complicated, preferably this should be fixed by patching or using REINPLACE_CMD to install with proper names. If not possible this should be at least converted to loop, bonus points for using ETCDIR var. rc.d script needs to be checked against: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html +@mode 755 +@dir /var/db/arangodb +@dir /var/db/arangodb/lib +@dir /var/db/arangodb/log Can be converted to: @dir(,,755) ${dir} +@owner arangodb +@group arangodb +@dir /var/db/arangodb/lib/arangodb +@dir /var/db/arangodb/lib/arangodb-apps +@dir /var/db/arangodb/log/arangodb Can be converted to: @dir(arangodb,arangodb,755) ${dir} Also fails make check-plist: ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: share/man/man1/arangob.1 Error: Orphaned: share/man/man1/arangodump.1 Error: Orphaned: share/man/man1/arangoimp.1 Error: Orphaned: share/man/man1/arangorestore.1 Error: Orphaned: share/man/man1/arangosh.1 Error: Orphaned: share/man/man8/arango-dfdb.8 Error: Orphaned: share/man/man8/arangod.8 Error: Orphaned: share/man/man8/foxx-manager.8 Error: Orphaned: share/man/man8/rcarangod.8 ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1 -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-195451-13-zo19E2TNUh>