Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 25 May 2016 11:02:53 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 209742] devel/godot: Improve port (v2.0.3)
Message-ID:  <bug-209742-13-XB9fSr42iA@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-209742-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-209742-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209742

--- Comment #7 from FreeBSD@ShaneWare.Biz ---
With the license, it seems adding LICENSE_FILE is right and adding CC for t=
he
icon I missed is good. I would suggest you consider submitting a patch to
update Mk/bsd.license.db.mk with the CC variations, maybe with a patch that
also updates the various ports that currently have their own CC info.

The audio options is a good idea, though I'm not sure it's complete yet. I
would choose rtaudio as the default as I find it more reliable than alsa. I
should look into the audio more, but building godot 2.0 I found the default
audio failed. It turned out that alsa was sending audio directly to /dev/ds=
p0
while my speakers are attached to dsp2, going through rtaudio gets the outp=
ut
right.

Using rtaudio isn't exclusive, it needs the alsa or pulse libs to work. Whi=
le
enabling rtaudio and using alsa or pulse works for me, godot talking straig=
ht
to alsa failed. As rtaudio is a few files included with godot it could stay
enabled rather than patching the other audio code. rtaudio also knows about
LINUX OSS so if we get that working we could drop using audio libs from oth=
er
ports and just use the built-in system sound. For now I think leave rtaudio
enabled but choose between alsa and pulse using an OPTION_SINGLE.

Yes I did forget to install the icon, I think both the svg and png should be
installed - and always, not just with tools enabled.

Using release_debug is worthwhile, I'm even thinking we should only use rel=
ease
or release_debug based on the tools selection. Maybe for anyone wanting a f=
ull
debug version we could have a note saying add GODOT_DEBUG=3Dyes in your mak=
e.conf
and that will use debug instead of release_debug.

As for the extra tools port - I don't think there is a need for that. The b=
uild
with the tools enabled works as a runtime. Although I do see a build without
tools being useful, at this stage we don't have the games available for peo=
ple
to use a runtime only build. I had thought of removing tools from default o=
nce
there are some games available, for now anyone installing godot is installi=
ng
to use the tools to make a game.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209742-13-XB9fSr42iA>