From owner-freebsd-current@FreeBSD.ORG Fri May 18 18:11:46 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AA991106566C for ; Fri, 18 May 2012 18:11:46 +0000 (UTC) (envelope-from pfg@freebsd.org) Received: from nm10.bullet.mail.bf1.yahoo.com (nm10.bullet.mail.bf1.yahoo.com [98.139.212.169]) by mx1.freebsd.org (Postfix) with SMTP id 472D68FC08 for ; Fri, 18 May 2012 18:11:46 +0000 (UTC) Received: from [98.139.212.145] by nm10.bullet.mail.bf1.yahoo.com with NNFMP; 18 May 2012 18:11:40 -0000 Received: from [98.139.211.198] by tm2.bullet.mail.bf1.yahoo.com with NNFMP; 18 May 2012 18:11:40 -0000 Received: from [127.0.0.1] by smtp207.mail.bf1.yahoo.com with NNFMP; 18 May 2012 18:11:40 -0000 X-Yahoo-Newman-Id: 511778.84696.bm@smtp207.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 8R4xXCMVM1nII.uBiZw9JBuCAB20WzaEP7EPFmc4FhSHvuF Ps5yoU3bmDiMn4_Bs6JxJ96c1J.Qt6nHi1JzohryJCeJHrcYIAwboRMAf18J CtYQnk36reUek8Qh4rVopML.p_hywny4Ymv2wIGLwmTpYgdjQY8GISXr5wht EdtzuMYortuvIs.9HvGshOJtekqeDxR_K9Gu.2AiMvP4NZ9jA_dt1RaP0F6K 8OrSPx7qMwILmeAHzqti_LYJiOgssAtOJ3_Y.VMYmHoHJy4QrmwJJKNG0GQE b3VTXTXq8HrhxLXLEOFNGSkkePSJ3mdTtcw4OxkByxhGK7GTdvJh7kGrSef_ vVeVwYZc6ZbeT_akN9fL9smFN.8SDEvtsLyS4mHmks0Hgfpcdrfpp0xAfqUX N.J4fVu4AMibz3HB2rabaTUSJpvus4_Dyw3eoUti6CX7du3Vb8aTZP69XrN. T5LDWL3_IYsUEbzO7qTXfh6oGzkhKvfJnRjGjMMGuYWfiqAfRyPpMRR_GTZE 8g8cVoock5A0YZ1FZquAXdH_LNKgxp9i24w-- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Received: from [192.168.10.103] (pfg@200.118.157.7 with plain) by smtp207.mail.bf1.yahoo.com with SMTP; 18 May 2012 11:11:40 -0700 PDT Message-ID: <4FB690DA.8060203@FreeBSD.org> Date: Fri, 18 May 2012 13:11:38 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:10.0.3) Gecko/20120328 Thunderbird/10.0.3 MIME-Version: 1.0 To: Dimitry Andric References: <4FB51CDF.3040306@FreeBSD.org> <4FB52AF9.1010306@andric.com> In-Reply-To: <4FB52AF9.1010306@andric.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@FreeBSD.org, freebsd-toolchain@FreeBSD.org Subject: Re: GCC update for testing X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 May 2012 18:11:46 -0000 Hi again; On 05/17/12 11:44, Dimitry Andric wrote: > On 2012-05-17 17:44, Pedro Giffuni wrote:> Hi; >> I took a bunch of patches that were merged into the GCC 4.1 branch >> (under GPLv2) and prepared a patch for merging them into our base >> gcc. These are supposed to be bug fixes only. >> >> You can get the patch here: >> http://people.freebsd.org/~pfg/patches/patch-contrib-gcc >> And, for those really interested, the log is here: >> http://people.freebsd.org/~pfg/patches/gcc41-pr-log >> >> It may be my imagination but the patch seems to be causing more >> warnings than usual and it breaks the kernel here: > ... >> ../../../cam/scsi/scsi_sa.c: In function 'samount': >> ../../../cam/scsi/scsi_sa.c:1887: warning: 'comp_supported' may be used >> uninitialized in this function >> ../../../cam/scsi/scsi_sa.c:1888: warning: 'write_protect' may be used >> uninitialized in this function > These warnings seem wrong, upon casual inspection of the code. In any > case, if you compile the same file with gcc 4.7, they don't appear. :) > > Any idea which particular gcc fix is responsible for them? > > As a workaround, we could set all those variable to some reasonable > value, but that feels like a cheap trick to me... > > But I'd rather just not import the fix that causes those warnings. Ugh... It appears the patch was fine after all: the warnings were somehow triggered by optimizations in my /etc/make.conf file. I will test it further before committing. Pedro.