From owner-freebsd-stable@FreeBSD.ORG Sun Dec 14 09:57:53 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A98E31065678 for ; Sun, 14 Dec 2008 09:57:53 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.delphij.net (delphij-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:2c9::2]) by mx1.freebsd.org (Postfix) with ESMTP id 3D0908FC22 for ; Sun, 14 Dec 2008 09:57:53 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [211.166.10.233]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.delphij.net (Postfix) with ESMTPS id 3E5CF28448 for ; Sun, 14 Dec 2008 17:57:52 +0800 (CST) Received: from localhost (tarsier.geekcn.org [211.166.10.233]) by tarsier.geekcn.org (Postfix) with ESMTP id 9FC5DEC4A3E; Sun, 14 Dec 2008 17:57:51 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([211.166.10.233]) by localhost (mail.geekcn.org [211.166.10.233]) (amavisd-new, port 10024) with ESMTP id jMiN03E8JIiM; Sun, 14 Dec 2008 17:57:46 +0800 (CST) Received: from charlie.delphij.net (c-67-180-38-12.hsd1.ca.comcast.net [67.180.38.12]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id 398A9EC4A37; Sun, 14 Dec 2008 17:57:43 +0800 (CST) Message-ID: <4944D894.6070306@delphij.net> Date: Sun, 14 Dec 2008 01:57:40 -0800 From: Xin LI Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.18 (X11/20081125) MIME-Version: 1.0 To: Mike Jakubik References: <4935069A.8060209@ec-marseille.fr> <49357BD0.4000008@delphij.net> <4935944A.9090509@ec-marseille.fr> <4935C453.8070301@delphij.net> <4935D67E.4070204@delphij.net> <4936F8C4.6090006@ec-marseille.fr> <49399FA6.3060108@delphij.net> <493CE8F7.5010204@yandex-team.ru> <3a6fb7145a0a6c8af136ea1a0824e5ed.squirrel@wettoast.dyndns.org> <493D9BC6.8050902@delphij.net> <4fe0419b44a3a4c4a28b1e60fbb3a3c8.squirrel@wettoast.dyndns.org> <56272b131067237ccabd23de5f669458.squirrel@wettoast.dyndns.org> In-Reply-To: <56272b131067237ccabd23de5f669458.squirrel@wettoast.dyndns.org> X-Enigmail-Version: 0.95.7 OpenPGP: id=18EDEBA0; url=http://www.delphij.net/delphij.asc Content-Type: multipart/mixed; boundary="------------040906020000020207050201" Cc: freebsd-stable@freebsd.org, d@delphij.net Subject: Re: RELENG_7_1: bce driver change generating too much interrupts ? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Dec 2008 09:57:53 -0000 This is a multi-part message in MIME format. --------------040906020000020207050201 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Mike Jakubik wrote: > On Mon, December 8, 2008 5:22 pm, Mike Jakubik wrote: >> On Mon, December 8, 2008 5:12 pm, Xin LI wrote: >> >>> Which version are you currently using? My previous commit only fixes >>> the excessive interrupt issue, I think this could be a different >>> problem, I'm taking a look at the code to see if I can have something >>> for you. >> I was running on the version just prior to the latest interrupt commit. I >> have now updated to the one with the interrupt fix. Will let you know if >> things change. >> >> Thank You. > > The interrupt rate has decreased significantly, however i am still having > having problem with applications that hold stateful connections. The rx > errors are also still showing, i suspect this is related to the problem. > How can i roll back this driver to the last known good version? Hi, Mike, I think they are different problems. Could you, please, give me feedback about whether: - The old driver does not trigger the problem? - The patched driver restore all the old driver behavior? ============= Rationale for my patch. To say it simply, it removes "Received L2 packets discarded" value from being counted from ierror. In the past, we count the following: - Undersize packets - Oversized packets - Received packets discarded due to lack of controller buffer memory - Alignment errors - Frame check sequence errors Now, it counts the following four stuff as well: - Received L2 packets discarded ** removed - Received packets discarded by rule - Received packet FTQ discards - Valid packets received but no RX buffers available I have checked the old FreeBSD driver and the Linux driver, both have the "Received L2 packets discarded" value increasing every second, so I don't believe that this is a real problem. I'll double check with David to make sure about this. Cheers, - -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAklE2JQACgkQi+vbBBjt66Bl0gCfZ6NVNXpC2ynUZjaZButg+4jo vgYAnAzE2iFWcZMZ29j3qtpwQ5f0xh9V =3l8f -----END PGP SIGNATURE----- --------------040906020000020207050201 Content-Type: text/plain; name="bce-noL2Filter.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="bce-noL2Filter.diff" Index: if_bce.c =================================================================== --- if_bce.c (revision 186076) +++ if_bce.c (working copy) @@ -7408,7 +7408,6 @@ (u_long) sc->stat_IfInMBUFDiscards + (u_long) sc->stat_Dot3StatsAlignmentErrors + (u_long) sc->stat_Dot3StatsFCSErrors + - (u_long) sc->stat_IfInFramesL2FilterDiscards + (u_long) sc->stat_IfInRuleCheckerDiscards + (u_long) sc->stat_IfInFTQDiscards + (u_long) sc->com_no_buffers; --------------040906020000020207050201--