From owner-freebsd-current@FreeBSD.ORG Mon May 14 00:49:15 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DEEDD106566C for ; Mon, 14 May 2012 00:49:14 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 8EDF48FC1A for ; Mon, 14 May 2012 00:49:14 +0000 (UTC) Received: by vbmv11 with SMTP id v11so5935166vbm.13 for ; Sun, 13 May 2012 17:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=bk7zDYv+5keVcW5k5A8ipHHokObrA2l3dYez4Ua7YnE=; b=DbzsrsAW5UnhUhAbXNC6iSBaB3ep0quYt8IZdAuQWpRM1neRwETe3Q+SN2p21PVwWF 02K73BzqKLJvNJ1QzLxwRQT5iUxwEoz3ivA9gYwuxaJDGA/bR8LuzikwI4EAjayhv9lP AsRit6wfEUlSLnEMzJ19IO2SpfAwG5SfkA/3pOkVHcpx1H1+vKqyOhyvf0g93I9SY3Qr MgHJaAmj+1HFut/WZkk3TNmyjByKQdDY5qIuy5NRiHgD+gRcp1SvWxyoUPviCZev8ael LjmXfOBT6k5OC1liZJD2BuBab54Wx9eW23ME/qNeKdpr6poIQan7qpJMN5xAGyKhmc80 /vmg== MIME-Version: 1.0 Received: by 10.52.100.9 with SMTP id eu9mr3208925vdb.28.1336956553688; Sun, 13 May 2012 17:49:13 -0700 (PDT) Received: by 10.220.7.148 with HTTP; Sun, 13 May 2012 17:49:13 -0700 (PDT) In-Reply-To: References: Date: Sun, 13 May 2012 17:49:13 -0700 Message-ID: From: Garrett Cooper To: Outback Dingo Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current Subject: Re: FYI FreeBSD clang build fails on new import of sort X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2012 00:49:15 -0000 On Sun, May 13, 2012 at 5:02 PM, Outback Dingo wro= te: > trying to rerun a clang build of FreeBSD CURRENT fails on new import of s= ort, > > cat /etc/src.conf > WITH_CLANG_IS_CC=3D1 > make world > ---------------------SNIP--------------------------- > clang -O2 -pipe =A0-DSORT_THREADS -std=3Dgnu99 -Qunused-arguments > -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W > -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes > -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch > -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline > -Wnested-externs -Wredundant-decls -Wold-style-definition > -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c > /usr/src/usr.bin/sort/coll.c > clang -O2 -pipe =A0-DSORT_THREADS -std=3Dgnu99 -Qunused-arguments > -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W > -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes > -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch > -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline > -Wnested-externs -Wredundant-decls -Wold-style-definition > -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c > /usr/src/usr.bin/sort/file.c > /usr/src/usr.bin/sort/file.c:601:12: error: format string is not a > string literal (potentially insecure) [-Werror,-Wformat-security] > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0err(2, get= str(7)); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 ^~~~~~~~~ > /usr/src/usr.bin/sort/sort.h:52:20: note: expanded from macro 'getstr' > #define getstr(n) =A0 =A0 =A0 =A0catgets(catalog, 1, n, nlsstr[n]) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~ > /usr/src/usr.bin/sort/file.c:942:11: error: format string is not a > string literal (potentially insecure) [-Werror,-Wformat-security] > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0err(2, getstr(8)); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~ > /usr/src/usr.bin/sort/sort.h:52:20: note: expanded from macro 'getstr' > #define getstr(n) =A0 =A0 =A0 =A0catgets(catalog, 1, n, nlsstr[n]) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~ > /usr/src/usr.bin/sort/file.c:1279:10: error: format string is not a > string literal (potentially insecure) [-Werror,-Wformat-security] > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0err(2, getstr(9)); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~ > /usr/src/usr.bin/sort/sort.h:52:20: note: expanded from macro 'getstr' > #define getstr(n) =A0 =A0 =A0 =A0catgets(catalog, 1, n, nlsstr[n]) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~ > /usr/src/usr.bin/sort/file.c:1295:12: error: format string is not a > string literal (potentially insecure) [-Werror,-Wformat-security] > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0errx(2, getstr(10)); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0^~~~~~~~~~ > /usr/src/usr.bin/sort/sort.h:52:20: note: expanded from macro 'getstr' > #define getstr(n) =A0 =A0 =A0 =A0catgets(catalog, 1, n, nlsstr[n]) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~ > 4 errors generated. > *** [file.o] Error code 1 > > Stop in /usr/src/usr.bin/sort. Yeah... errx(2, getstr(9)) should be errx(2, "%s", getstr(9))... -Garrett