From owner-svn-src-all@freebsd.org Tue Jan 24 22:20:56 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D1E0CBFAB9; Tue, 24 Jan 2017 22:20:56 +0000 (UTC) (envelope-from decui@microsoft.com) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0113.outbound.protection.outlook.com [104.47.36.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AE518B8F; Tue, 24 Jan 2017 22:20:55 +0000 (UTC) (envelope-from decui@microsoft.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=IhfhCdDmFeoC7OjfPf0zsj+6wxYow3iDrTLZR7xwYMg=; b=F/7YEa2nXT5CpKCUkj1Uog6bcbvgBONiMqm3ylTDqOe1s/bTyIm1mHbG+8C2I3oZh71zrlIthB1ftOAJz6wV4LJaz30Wvl6FR3HMc5rIw+7PjDGc7czgqEsV+LfR9c5LyAKoMqH4D4CiNkkeLTPoz2ILOorrP1d3RQkYtuE78ko= Received: from MWHPR03MB2669.namprd03.prod.outlook.com (10.168.207.15) by MWHPR03MB2670.namprd03.prod.outlook.com (10.168.207.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13; Tue, 24 Jan 2017 22:20:53 +0000 Received: from MWHPR03MB2669.namprd03.prod.outlook.com ([10.168.207.15]) by MWHPR03MB2669.namprd03.prod.outlook.com ([10.168.207.15]) with mapi id 15.01.0860.021; Tue, 24 Jan 2017 22:20:53 +0000 From: Dexuan Cui To: Gleb Smirnoff , Dexuan Cui CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: RE: svn commit: r312687 - in head/sys: net sys Thread-Topic: svn commit: r312687 - in head/sys: net sys Thread-Index: AQHSdnftoCXmn3KP+kO3oJR5DjhMrKFIMlEw Date: Tue, 24 Jan 2017 22:20:53 +0000 Message-ID: References: <201701240919.v0O9JlM7021007@repo.freebsd.org> <20170124192725.GX2611@FreeBSD.org> In-Reply-To: <20170124192725.GX2611@FreeBSD.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=decui@microsoft.com; x-originating-ip: [139.226.141.22] x-ms-office365-filtering-correlation-id: 38c5bb1d-b56c-48b2-e256-08d444a742bb x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR03MB2670; x-microsoft-exchange-diagnostics: 1; MWHPR03MB2670; 7:OxK4EIQNVK5DppB/SsUOi8PS+ocz3kmr7kdymci07SXDEG7ogvNFwx6wWY5jY27JCLSPNl2Xcv//VWP7jG5UtHXI2emPdJLGIvmt59uODAvljcwcCWUTjx5zJ3oUlJ6qrs5zlXBOM7LiF2BNK6/jDXsqJ4NlpRBVx1UKXO9pzLg+jwg/DrQg18D0Ad9aLlDtwYQKbS28XbxepDOemIdb6NHoqjXUU9BsU5cYbn3z0n45dTt3oHNsgYfLLlplZORTC1w4FxcI3md4ofdmO8DR3Nco0nFhn6hksSIv+SsGZD5i0NXq4ZatD9BnnMruB7lG/AiDPqCnUaB4pu7i6DwfBfAiBlUXoJQl6DJD7BxgAZXQZc+O4UJ9jAzLf3Ee0frut26mnOAOR5p1AOFafGv8ugLDZSb4wEIKvDjE8UgWI9wW27N0SPsxCOurK75PPFwN0mdhf7Cz/HUDwO0+DY+bJfLPcopLe8RviX7XIaJfhUU= x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041248)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(6072148)(6047074); SRVR:MWHPR03MB2670; BCL:0; PCL:0; RULEID:; SRVR:MWHPR03MB2670; x-forefront-prvs: 0197AFBD92 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(39450400003)(39850400002)(39860400002)(39410400002)(39840400002)(24454002)(189002)(199003)(101416001)(305945005)(92566002)(74316002)(106356001)(105586002)(10090500001)(189998001)(106116001)(76176999)(5660300001)(7736002)(50986999)(86362001)(54356999)(2950100002)(7696004)(86612001)(68736007)(5001770100001)(66066001)(97736004)(2900100001)(81166006)(6506006)(6116002)(3846002)(38730400001)(33656002)(229853002)(122556002)(450100001)(6436002)(3660700001)(2906002)(4326007)(102836003)(54906002)(8990500004)(8676002)(55016002)(9686003)(10290500002)(99286003)(5005710100001)(345774005)(3280700002)(81156014)(25786008)(8936002)(77096006)(53936002); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR03MB2670; H:MWHPR03MB2669.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2017 22:20:53.2826 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2670 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2017 22:20:56 -0000 > From: Gleb Smirnoff [mailto:glebius@FreeBSD.org] > Dexuan, >=20 > On Tue, Jan 24, 2017 at 09:19:47AM +0000, Dexuan Cui wrote: > D> --- head/sys/sys/eventhandler.h Tue Jan 24 09:15:36 2017 > (r312686) > D> +++ head/sys/sys/eventhandler.h Tue Jan 24 09:19:46 2017 > (r312687) > D> @@ -284,4 +284,11 @@ typedef void (*swapoff_fn)(void *, struc > D> EVENTHANDLER_DECLARE(swapon, swapon_fn); > D> EVENTHANDLER_DECLARE(swapoff, swapoff_fn); > D> > D> +/* ifup/ifdown events */ > D> +#define IFNET_EVENT_UP 0 > D> +#define IFNET_EVENT_DOWN 1 > D> +struct ifnet; > D> +typedef void (*ifnet_event_fn)(void *, struct ifnet *ifp, int event); > D> +EVENTHANDLER_DECLARE(ifnet_event, ifnet_event_fn); > D> + > D> #endif /* _SYS_EVENTHANDLER_H_ */ >=20 > The network stuff shall not be added to sys/eventhandler.h. >=20 > All these declarations should go to net/if_var.h. There is already > a block of event(9) defines there. Please move it there. >=20 > -- > Totus tuus, Glebius. Hi Gleb, Sorry, I didn't realize this... I'll move it as you suggested. Thank you for the reminder! -- Dexuan