From owner-svn-src-head@freebsd.org Tue May 10 15:56:10 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2D8FDB3597D; Tue, 10 May 2016 15:56:10 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 097BB1D8F; Tue, 10 May 2016 15:56:10 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id C1C4BB97D; Tue, 10 May 2016 11:56:08 -0400 (EDT) From: John Baldwin To: Hans Petter Selasky Cc: Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r299363 - head/sys/compat/linuxkpi/common/include/asm Date: Tue, 10 May 2016 08:55:57 -0700 Message-ID: <4312956.Tckd6PoFKf@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <7693af09-def2-e8a7-b7fd-9b6df41908cc@selasky.org> References: <201605101139.u4ABdaTL098171@repo.freebsd.org> <7693af09-def2-e8a7-b7fd-9b6df41908cc@selasky.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 10 May 2016 11:56:08 -0400 (EDT) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2016 15:56:10 -0000 On Tuesday, May 10, 2016 05:06:08 PM Hans Petter Selasky wrote: > On 05/10/16 13:39, Hans Petter Selasky wrote: > > Author: hselasky > > Date: Tue May 10 11:39:36 2016 > > New Revision: 299363 > > URL: https://svnweb.freebsd.org/changeset/base/299363 > > > > Log: > > Use function macros when possible to avoid stray substitutions. > > > > MFC after: 1 week > > Sponsored by: Mellanox Technologies > > > > FYI > > This change accidentially broke LINT and I have a patch waiting for > review from the Chelsio guys that will fix LINT and WITH_OFED=YES again. > Will hopefully be fixed shortly. Is the reason for the change to avoid accepting the wrong number of arguments (e.g. cpu_to_be32(x, y))? Won't that still fail to compile if so? (That is, the reasoning for why you made the original change isn't clear to me from the commit.) -- John Baldwin