Date: Mon, 22 Jan 2018 23:38:33 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Eugene Grosbein <eugen@freebsd.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r459676 - in head/sysutils/zfsnap: . files Message-ID: <20180122223833.zb6fbfh7bl5lwt7e@atuin.in.mat.cc> In-Reply-To: <5A6652F6.4000406@freebsd.org> References: <201801221705.w0MH5n8N044357@repo.freebsd.org> <20180122172614.ptlibdvjq42myqzp@aragorn.in.absolight.net> <5A662E1F.6010408@freebsd.org> <20180122192531.7xs4zndt6wrh3nbq@atuin.in.mat.cc> <5A6652F6.4000406@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--liti2ixctonhzcvg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 22, 2018 at 09:09:10PM +0000, Eugene Grosbein wrote: > 23.01.2018 2:25, Mathieu Arnold wrote: >=20 > > On Mon, Jan 22, 2018 at 06:31:59PM +0000, Eugene Grosbein wrote: > >> 23.01.2018 0:26, Mathieu Arnold wrote: > >> > >>> On Mon, Jan 22, 2018 at 05:05:49PM +0000, Eugene Grosbein wrote: > >>>> Move creation of files from "do-patch" to "post-extract" target, > >>>> so that patches from files/ directory get applied. > >>>> =20 > >>>> -do-patch: > >>>> +post-extract: > >>> > >>> I am sure you meant to use post-extract here. > >> > >> And I did. What is a problem here? > >=20 > > Sorry, meant post-patch here. >=20 > "post-patch" means we will not be able conditionally patch generated file= s with extra-patches, for example. > As we could not apply simple patch before this change due to abuse of "do= -patch". > So, "post-extract" is intentional. post-extract is for extracting more files, or copying files in WRKSRC. Patching must be done in a *-patch target, be it pre-patch or post-patch. Of course you can use makepatch, if the patches does not touch files you change in post-patch, you can run makepatch without thinking about it. If you do also change those files, you can run: make extract do-patch makepatch So, please, use post-patch. --=20 Mathieu Arnold --liti2ixctonhzcvg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAABCgBmBQJaZmfpXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IYlsQALjhl80YGg/76IH4TwB9OA1T COprY/tfTGwsItEHd/JHUneTWW9SPera1FkRvjMPA7jkI6mVjzIn94JnRfAODdml 3mnIkWsFN/JEQcpyxsZiGCH2N7DGTmwCMQDej3WYwR6dxI55nOlLQ5bBAVeWXzn5 YoY8MxjmAIcvtpTDEGUAYvCYLxs10OfsocF09qMh7NQC0uYJvUKXB2kbPcAFdVyX j7/0Jb5p2lwuURjG/RJa2LcgPyCwdZ2ll2+ctS5TYfNdN0rZGYA5BTiwrwWeKjzI J8cuB6UJVe9KojmIf4f3/0esPjbgzsDgj2o9hR3vsc6HinAI2rpZMuiKIajjU8CD +6t4DlNSdcoIFB7ds1+yHah4MaiMOeG4I7zsj+tuVfcYge14PGvFgHrOYR2RPijq dojlDVjsyzvsImCIZnYwqOiGMwwOV0Lz6AxWNdMLkZFPe0/OCNVOu7BtnwV2lk2N RH5yYZAUE6CA5Ybb42qLJWjMhiIgEYCyoqzWySjsC4dIo0YCm+PALLPcqUYfj5KX /7vCG8P2rQKTbfR9Zpe8RXZQmS9z5Ilj0IxLFgOrHU2ngtFv+NxDHB1fuGE1HKvD iiPlAkyAfKwEEmLnJXtn/NtTEz2KEJwNI2EPXWJuw8jd0UZiP5XO+8NxQfa++Z57 WyaZUx5a/BPxOcCbKIil =HRSj -----END PGP SIGNATURE----- --liti2ixctonhzcvg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180122223833.zb6fbfh7bl5lwt7e>