From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Jan 15 17:20:04 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 87CD316A41F for ; Sun, 15 Jan 2006 17:20:04 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D24F443D45 for ; Sun, 15 Jan 2006 17:20:03 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k0FHK3sA010636 for ; Sun, 15 Jan 2006 17:20:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k0FHK37K010634; Sun, 15 Jan 2006 17:20:03 GMT (envelope-from gnats) Resent-Date: Sun, 15 Jan 2006 17:20:03 GMT Resent-Message-Id: <200601151720.k0FHK37K010634@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dmitry Marakasov Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 39D8F16A420 for ; Sun, 15 Jan 2006 17:18:57 +0000 (GMT) (envelope-from amdmi3@mail.ru) Received: from mx3.mail.ru (mx3.mail.ru [194.67.23.149]) by mx1.FreeBSD.org (Postfix) with ESMTP id 959C543D49 for ; Sun, 15 Jan 2006 17:18:56 +0000 (GMT) (envelope-from amdmi3@mail.ru) Received: from [213.148.29.33] (port=25906 helo=nexii.panopticon) by mx3.mail.ru with esmtp id 1EyBWp-000IR4-00 for FreeBSD-gnats-submit@freebsd.org; Sun, 15 Jan 2006 20:18:55 +0300 Received: from hades.panopticon (hades.panopticon [192.168.0.2]) by nexii.panopticon (Postfix) with ESMTP id 7077C1140E for ; Sun, 15 Jan 2006 20:21:49 +0300 (MSK) Received: by hades.panopticon (Postfix, from userid 1000) id 4449D5A; Sun, 15 Jan 2006 20:23:04 +0300 (MSK) Message-Id: <20060115172304.4449D5A@hades.panopticon> Date: Sun, 15 Jan 2006 20:23:04 +0300 (MSK) From: Dmitry Marakasov To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/91834: [PATCH] Cleaner use of INSTALLS_OMF with no scrollkeeper installed X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dmitry Marakasov List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jan 2006 17:20:04 -0000 >Number: 91834 >Category: ports >Synopsis: [PATCH] Cleaner use of INSTALLS_OMF with no scrollkeeper installed >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Jan 15 17:20:03 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Dmitry Marakasov >Release: FreeBSD 6.0-RELEASE i386 >Organization: >Environment: System: FreeBSD hades.panopticon 6.0-RELEASE FreeBSD 6.0-RELEASE #1: Sun Dec 18 08:07:07 MSK 2005 amdmi3@hades.panopticon:/usr/obj/usr/src/sys/HADES i386 >Description: Some ports install .omf (opensource metadata framework) files, which are intended for use with scrollkeeper (ports/textproc/scrollkeeper). As these files need to be registered with scrollkeper, there's knob INSTALLS_OMF, which, if set, makes bsd.gnome.mk automatically add @exec/@unexec directives to ports' plist. These do scrollkeeper-install/scrollkeeper-uninstall calls on package installation/deinstallation. But when scrollkeeper is not installed on a system, errors will appear: `scrollkeeper-install: not found' `scrollkeeper-uninstall: not found' on installation/deinstallation of a package because nonexisting binaries are being called. These errors are harmless, as scrollkeeper calls are done as `scrollkeeper-(un)install || true', but still annoying/confusing. That is, of course, bad idea to add dependency on scrollkeeper to ports that just INSTALLS_OMF, so I recommend to modify bsd.gnome.mk a little, so before calling scrollkeeper-(un)install it will be checked for existence with `which -s'. !!! Also, I've just found out that when installing software from port, scrollkeeper-install doesn't get called at all (as @exec is only called when installing prom package). I have no fix for that yet. >How-To-Repeat: >Fix: --- bsd.gnome.mk.patch begins here --- --- bsd.gnome.mk.orig Tue Jan 10 18:23:54 2006 +++ bsd.gnome.mk Sun Jan 15 19:34:37 2006 @@ -730,9 +730,9 @@ . if defined(INSTALLS_OMF) @for i in `${GREP} "\.omf$$" ${TMPPLIST}`; do \ - ${ECHO_CMD} "@exec scrollkeeper-install -q %D/$${i} 2>/dev/null || /usr/bin/true" \ + ${ECHO_CMD} "@exec which -s scrollkeeper-install && scrollkeeper-install -q %D/$${i} 2>/dev/null || /usr/bin/true" \ >> ${TMPPLIST}; \ - ${ECHO_CMD} "@unexec scrollkeeper-uninstall -q %D/$${i} 2>/dev/null || /usr/bin/true" \ + ${ECHO_CMD} "@unexec which -s scrollkeeper-uninstall && scrollkeeper-uninstall -q %D/$${i} 2>/dev/null || /usr/bin/true" \ >> ${TMPPLIST}; \ done . endif --- bsd.gnome.mk.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: