From owner-freebsd-ports-bugs@FreeBSD.ORG  Tue Mar 24 13:44:00 2015
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5B825871
 for <freebsd-ports-bugs@FreeBSD.org>; Tue, 24 Mar 2015 13:44:00 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 282F7A35
 for <freebsd-ports-bugs@FreeBSD.org>; Tue, 24 Mar 2015 13:44:00 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t2ODi0FL043981
 for <freebsd-ports-bugs@FreeBSD.org>; Tue, 24 Mar 2015 13:44:00 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 198869] USE_GITHUB doesn't set WRKSRC correctly.
Date: Tue, 24 Mar 2015 13:44:00 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Ports Framework
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: amdmi3@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: portmgr@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter cc
Message-ID: <bug-198869-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Mar 2015 13:44:00 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198869

            Bug ID: 198869
           Summary: USE_GITHUB doesn't set WRKSRC correctly.
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr@FreeBSD.org
          Reporter: amdmi3@FreeBSD.org
                CC: freebsd-ports-bugs@FreeBSD.org

USE_GITHUB sets WRKSRC incorrectly in some cases. For instance, see
games/freeblocks with removed GH_COMMIT. After `make fetch makesum extract`:

Index: Makefile
===================================================================
--- Makefile    (revision 382055)
+++ Makefile    (working copy)
@@ -14,7 +14,7 @@
 USE_GITHUB=    yes
 GH_ACCOUNT=    dorkster
 GH_TAGNAME=    v${PORTVERSION}
-GH_COMMIT=    3c58e62
+#GH_COMMIT=    3c58e62

 USES=        cmake
 CMAKE_ARGS=    -DDATADIR="${DATADIR_REL}"
Index: distinfo
===================================================================
--- distinfo    (revision 382055)
+++ distinfo    (working copy)
@@ -1,2 +1,2 @@
-SHA256 (freeblocks-0.5.tar.gz) =
0d24a2b61a504e76ea71b95436272353d1e74721438b158a31706dd211866e9c
-SIZE (freeblocks-0.5.tar.gz) = 7914638
+SHA256 (dorkster-freeblocks-0.5-v0.5_GH0.tar.gz) =
8da72ccf7bcba585fcd8b65943f590f51aff06286f3ed920a13c0c90fb392e06
+SIZE (dorkster-freeblocks-0.5-v0.5_GH0.tar.gz) = 7914439

% make -V WRKSRC 
.../games/freeblocks/work/freeblocks-v0.5
% ls work
freeblocks-0.5

As I understand, github removes leading v from the tag name, so we should do
the same.

-- 
You are receiving this mail because:
You are on the CC list for the bug.