From owner-freebsd-net@FreeBSD.ORG Wed Jun 20 21:02:22 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A8DDE1065742 for ; Wed, 20 Jun 2012 21:02:22 +0000 (UTC) (envelope-from rpaulo@FreeBSD.org) Received: from felyko.com (stark.strangled.net [IPv6:2607:f2f8:a528::3:1337:ca7]) by mx1.freebsd.org (Postfix) with ESMTP id 6EC1D8FC19 for ; Wed, 20 Jun 2012 21:02:22 +0000 (UTC) Received: from [IPv6:2620:149:4:f01:95db:5be2:ed96:7cb] (unknown [IPv6:2620:149:4:f01:95db:5be2:ed96:7cb]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by felyko.com (Postfix) with ESMTPSA id F20FC3EC3A; Wed, 20 Jun 2012 14:02:21 -0700 (PDT) Content-Type: text/plain; charset=GB2312 Mime-Version: 1.0 (Mac OS X Mail 6.0 \(1477\)) From: Rui Paulo In-Reply-To: Date: Wed, 20 Jun 2012 14:02:21 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <39BF633E-25BE-4382-A6BC-FB788566447B@FreeBSD.org> References: To: GuYong X-Mailer: Apple Mail (2.1477) Cc: freebsd-net@freebsd.org Subject: Re: Question about MLDv2 implemenation in Kernel X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2012 21:02:22 -0000 Hi, On 20 Jun 2012, at 01:12, GuYong wrote: >=20 > Hi, everyone, > I'm looking at the MLDv2 implemenation in kernel, and there seem to be = some issues, could anyone confirm them? > 1. RFC3810 clause 6.1 mentions there is a Source Retransmission = Counter associated to each source, so that the merged report could = contain the content that is interrupted by a new state change report = BUT, I didn't see this is implemented currently! > 2. Regarding the 'Older Version Querier Present timer', the code is = like this:old_version_timer =3D (mli->mli_rv * mli->mli_qi) + = mli->mli_qri; > while mli->mli_qri =3D maxdelay, and maxdelay =3D = ntohs(mld->mld_maxdelay). BUT, mld_maxdelay is in units of = milliseconds (clause 5.1.3), I think it should be divided by 1000 before = it adds to old_version_timer. >=20 > 3. According to RFC, a node MUST accept and process any Query whose = IP Destination Address field contains *any* of the address (unicast or = multicast) assigned to the interface on which the Query arrives. = BUT, I see the code only accept General Query addressed to FF02::1. I kindly ask you to submit a problem report at = http://www.freebsd.org/send-pr.html so this doesn't get lost. Did you = find these issues by code inspection or when using a test suite? Do you = have any patches? Thanks, -- Rui Paulo