Date: Mon, 03 Aug 2020 22:51:28 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 248460] devel/sigar: fix after filedesc struct change Message-ID: <bug-248460-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D248460 Bug ID: 248460 Summary: devel/sigar: fix after filedesc struct change Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: ronald-lists@klop.ws Created attachment 216998 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D216998&action= =3Dedit rename fd_lastfile to fd_nfiles (makepatch & svn diff) Port devel/sigar does not build on 13-CURRENT since base r363214. See bug #248453 for links to pkg logs about the breakage. The attached patch fixes it. The fix was suggested in a reply to https://lists.freebsd.org/pipermail/freebsd-ports/2020-August/119093.html by Mateusz Guzik (mjg). "I don't know what they used the counter for, the name "total" is a little worrisome. Nonetheless, I suspect the code will be fine enough by unconditionally doing: procfd->total =3D filed.fd_nfiles; However, this likely wants to stop using kvm in the first place. The kernel exports all necessary info using sysctls, see procstat." The code in the port is highly undocumented, but AFAIK it tries to get the number of open files of the current process. If this is committed it obsoletes bug #248453. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-248460-7788>