Date: Mon, 08 Sep 2014 16:29:34 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 193431] [MAINTAINER] lang/smlnj: update to 110.77 Message-ID: <bug-193431-13-4GlAieFQn4@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-193431-13@https.bugs.freebsd.org/bugzilla/> References: <bug-193431-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193431 --- Comment #2 from Johannes 5 <joemann@beefree.free.de> --- (In reply to Kubilay Kocak from comment #1) > Kubilay Kocak <koobs@FreeBSD.org> changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > Keywords| |needs-qa, patch > Severity|Affects Some People |Affects Only Me Sorry if it was inapproriate to initialize the severity of this PR with "Affects Some People". My intuition was that PRs like 191899 and 191504 indicate that it's not "Only Me" using the lang/smlnj port. I also couldn't find a reference within the porter's handbook to documentation of (the workflow used in) FreeBSD's bugzilla. > --- Comment #1 from Kubilay Kocak <koobs@FreeBSD.org> --- > If possible please also include the following to promote quick > resolution: > > * Attach successful poudriere testport, or redports.org build logs Unfortunately I don't currently have access to a machine where I could create ZFS file systems, which seems to be required by poudriere. Certainly redports.org will be helpful with testing package building, but before I'll start to explore anything new I'd like to finish lang/smlnj, which was keeping me busy for quite a while now:-) I also need a shell to test the functioning of the package and possibly debug its failures. But that would not be part of a reports.org account, right? > * portlint -AC output % uname -srm FreeBSD 10.0-STABLE i386 % grep FreeBSD: Makefile # $FreeBSD: head/lang/smlnj/Makefile 366742 2014-08-31 10:42:04Z pi $ % portlint -AC WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. WARN: Makefile: Consider defining LICENSE. 0 fatal errors and 2 warnings found. The porter's handbook does not seem to contain information on how to define a port's LICENSE. The first paragraph on www.smlnj.org states that "SML/NJ is free, open source software" and hyperlinks to the license [1]. I can't see harm for the FreeBSD project resulting from this license, which is also distributed as LICENSE file in smlnj-lib.tgz. But I'm not a lawyer and if someone tells me how to explicitly include that license into the port, I'll be glad to do that. % uname -srm FreeBSD 9.3-STABLE amd64 % grep FreeBSD: Makefile # $FreeBSD: head/lang/smlnj/Makefile 366742 2014-08-31 10:42:04Z pi $ % portlint -AC WARN: Makefile: POSITION64 appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE. WARN: Makefile: POSITION64 appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE. WARN: Makefile: RECOMPILE appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE. WARN: Makefile: RECOMPILE appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE. WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. WARN: Makefile: Consider defining LICENSE. 0 fatal errors and 6 warnings found. % make -V OPTIONS_DEFINE % I can't easily decide if those "PORT_OPTIONS:M" warnings are primarily caused by the port, portlint, or bsd.options.mk. This port does have a non-standard OPTIONS structure, because "higher" options imply "lower" options (POSITION64 => RECOMPILE => EVERYTHING). Additionally RECOMPILE (and hence POSITION64) breaks the port on amd64. So these have to be disabled on amd64. Unfortunately it doesn't help to put the offending part of the port's Makefile into a conditional like .if ${ARCH} == "i386" ... .endif. So it seems that I need advice on how to keep portlint from emitting those warnings. > (after addressing any outstanding issues) I built and tested the port on 9.3-STABLE amd64 and 10.0-STABLE i386. I could find no issues, neither with math/isabelle (make build) nor devel/asdlgen (make test-compile; make test-demo), which is currently dropped (but could be revived in the near future [2]). Thanks for your feedback, advice, and patience Johannes [1] <http://www.smlnj.org/license.html>; [2] <ftp://offshore.free.de/pub/patch/asdlgen.patch.20140907>; -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193431-13-4GlAieFQn4>