From owner-freebsd-net@FreeBSD.ORG Tue Jul 15 11:36:06 2014 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9C0ED872; Tue, 15 Jul 2014 11:36:06 +0000 (UTC) Received: from mail-vc0-x230.google.com (mail-vc0-x230.google.com [IPv6:2607:f8b0:400c:c03::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 40C962BF5; Tue, 15 Jul 2014 11:36:06 +0000 (UTC) Received: by mail-vc0-f176.google.com with SMTP id ik5so9847270vcb.35 for ; Tue, 15 Jul 2014 04:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=mS7JtPmz61C524kAn8UsUYs3HgqWHfsN4nj2EoxsM2M=; b=X50RsnR/ULkgxg/xdQCaTffJQi20acrcQJnQN/EPVUV3tS6ZO6rZtls2KAAgQPb1Di cpXrkbmkGP35ag5ZEdqVztxVSNbr4ZXeXYGBWp6+IY3nQcxm2bH/TRlfWwSbuLt6N/ls 5UucGZzNaNm+V7ib6St/Kp6jbusn4E58XNDMua6w2kqz70Y2IEMs8U6f7cc/KbdRKaOB OQJ//J8oAEEuesnedcel4MsKbGCl6Lbl/gQcPtBYgfZwCdHXNAailiNu6zMhO9vPPJyP YhKBa5u57UPXHDXYRSVkT3Zscza+9qb6KjUN5Wi3rkSkFQoqFwULosWXaGDEO7ELiIHY FdLQ== MIME-Version: 1.0 X-Received: by 10.221.59.194 with SMTP id wp2mr229982vcb.59.1405424165306; Tue, 15 Jul 2014 04:36:05 -0700 (PDT) Received: by 10.58.161.102 with HTTP; Tue, 15 Jul 2014 04:36:05 -0700 (PDT) In-Reply-To: References: <453BA9EC-BB63-4258-8141-847F41315E1E@sarenet.es> <6C8CF68D-68E2-4168-AA0A-6A629D363371@sarenet.es> Date: Tue, 15 Jul 2014 13:36:05 +0200 Message-ID: Subject: Re: Fix Emulex "oce" driver in CURRENT From: Stefano Garzarella To: Borja Marcos Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Cc: "freebsd-net@freebsd.org" , freebsd-current , Luigi Rizzo , Xin LI X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jul 2014 11:36:06 -0000 2014-07-15 12:00 GMT+02:00 Borja Marcos : > > On Jul 15, 2014, at 11:45 AM, Stefano Garzarella wrote: > > > I just tried to run iperf3 with this patch and STABLE-10 and it seems to > > work. > > Do you have a panic? > > So far, so good. I've ran a couple of iperf3 tests (60 seconds, trying > both directions) and it doesn't crash. > > Without the fixes I obtained a panic quite reliably, in less than 30 > seconds. > Still trying. But the bugs you mentioned (lack of locking and > deallocating, etc) seem to be consistent with the kind of failures I saw > and their apparent randomness. > Well. > > So, asking for spiritual counsel now. Would you use this driver in a > production environment instead of the 747 version downloaded from Emulex? I > think the latter is giving slightly better performance but, anyway, I > disable LRO and TSO because I see a horrible impact on NFS performance. > > I made a diff between the two versions (CURRENT and 747) and I saw that the main difference is in the management of buf_ring through drbr API. In the CURRENT driver they use a new function drbr_peek() instead of drbr_dequeue() and I think this is better. However, even in the 747 version seems to have the problem of the lack of locking. Cheers, Stefano Cheers, > > > > > > Borja. > > -- Stefano Garzarella