Date: Mon, 10 Dec 2001 00:24:38 -0800 (PST) From: Chi-Fung Fan <chifung@soda.CSUA.berkeley.edu> To: freebsd-gnats-submit@FreeBSD.org Subject: i386/32666: mbufs leaks in dev/ed Message-ID: <200112100824.fBA8Oc364430@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 32666
>Category: i386
>Synopsis: mbufs leaks in dev/ed
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Dec 10 00:30:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator: Chi-Fung Fan
>Release: 4.4
>Organization:
>Environment:
486 machine running as a home-network router using two ne2000 compatible nics. One nic is connected to at&t @home cable modem.
FreeBSD marx.rice.net 4.4-RELEASE FreeBSD 4.4-RELEASE #3: Sun Dec 9 15:07:33 PST 2001 root@marx.rice.net:/usr/src/sys/compile/MARX i386
>Description:
When ed0 is connected to a noisy network (e.g. @home network), ed_pio_write_mbufs() frequently fails to "wait for remote DMA complete."
The caller ed_start() doesn't free the mbuf when this happens resulting in mbufs leaks. This would eventually exhaust all the systems mbufs.
>How-To-Repeat:
connect to a noisy network and make sure you see many of
"ed0: remote transmit DMA failed to complete" messages.
>Fix:
In /usr/src/sys/dev/ed/if_ed.c function ed_start(ifp), add m_freem(m0)
before go back to loop.
len = ed_pio_write_mbufs(sc, m, (int)buffer);
if (len == 0) {
m_freem(m0); /* fix mbufs leak */
goto outloop;
}
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200112100824.fBA8Oc364430>