From owner-freebsd-bugs@FreeBSD.ORG  Thu Dec  6 13:30:01 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6F68116A477
	for <freebsd-bugs@hub.freebsd.org>;
	Thu,  6 Dec 2007 13:30:01 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 4E03E13C50F
	for <freebsd-bugs@hub.freebsd.org>;
	Thu,  6 Dec 2007 13:30:01 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id lB6DU1kM013446
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 6 Dec 2007 13:30:01 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id lB6DU1ss013445;
	Thu, 6 Dec 2007 13:30:01 GMT (envelope-from gnats)
Resent-Date: Thu, 6 Dec 2007 13:30:01 GMT
Resent-Message-Id: <200712061330.lB6DU1ss013445@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Edward Tomasz Napierala <trasz@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A73FB16A468
	for <freebsd-gnats-submit@FreeBSD.org>;
	Thu,  6 Dec 2007 13:22:13 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 9676A13C4E8
	for <freebsd-gnats-submit@FreeBSD.org>;
	Thu,  6 Dec 2007 13:22:13 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id lB6DM9dK018333
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 6 Dec 2007 13:22:09 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id lB6DM9s7018332;
	Thu, 6 Dec 2007 13:22:09 GMT (envelope-from nobody)
Message-Id: <200712061322.lB6DM9s7018332@www.freebsd.org>
Date: Thu, 6 Dec 2007 13:22:09 GMT
From: Edward Tomasz Napierala <trasz@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: misc/118461: humanize_number(3) incorrectly formats values from
	1048051712 to 1048575999 as "1000".
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Dec 2007 13:30:01 -0000


>Number:         118461
>Category:       misc
>Synopsis:       humanize_number(3) incorrectly formats values from 1048051712 to 1048575999  as "1000".
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 06 13:30:00 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     Edward Tomasz Napierala
>Release:        7.0-BETA3
>Organization:
>Environment:
FreeBSD traszkan.ds7 7.0-BETA4 FreeBSD 7.0-BETA4 #0: Thu Dec  6 10:04:38 CET 2007     trasz@traszkan.ds7:/usr/obj/site1/trasz/src/sys/TRASZKAN7  i386
>Description:
For values in range <1048051712, 1048575999>, humanize number incorrectly formats them as "1000" - the "M" prefix is missing.

This affects "df -h" output.  (That's how I found it.)

>How-To-Repeat:
#include <stdio.h>
#include <string.h>
#include <sys/param.h>
#include <libutil.h>

#define START 1024*1024*999
#define END 1024*1024*1001

int main(void)
{
        char buf[6];
        int64_t bytes;

        for (bytes = START; bytes < END; bytes++) {
                humanize_number(buf, sizeof(buf) - (bytes < 0 ? 0 : 1), bytes, "", HN_AUTOSCALE, HN_B | HN_NOSPACE | HN_DECIMAL);

                printf("%s\n", buf);

                if (strcmp(buf, "1000") == 0)
                        printf("Here, it's %ld\n", (long)bytes);
        }

        return 0;
}

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: