From owner-svn-src-head@freebsd.org Wed Mar 21 05:40:47 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 418A4F4A568; Wed, 21 Mar 2018 05:40:47 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by mx1.freebsd.org (Postfix) with ESMTP id 93E0B7CF83; Wed, 21 Mar 2018 05:40:46 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from [192.168.0.102] (c110-21-101-228.carlnfd1.nsw.optusnet.com.au [110.21.101.228]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 115F04284A7; Wed, 21 Mar 2018 16:40:38 +1100 (AEDT) Date: Wed, 21 Mar 2018 16:40:38 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Warner Losh cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r331269 - head/share/man/man9 In-Reply-To: <201803202137.w2KLbXrp071489@repo.freebsd.org> Message-ID: <20180321160918.T1241@besplex.bde.org> References: <201803202137.w2KLbXrp071489@repo.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=FNpr/6gs c=1 sm=1 tr=0 a=PalzARQSbocsUSjMRkwAPg==:117 a=PalzARQSbocsUSjMRkwAPg==:17 a=kj9zAlcOel0A:10 a=0GwoL8mGeRctihYA72gA:9 a=CjuIK1q_8ugA:10 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 05:40:47 -0000 On Tue, 20 Mar 2018, Warner Losh wrote: > Log: > Remove reference to lint. We no longer support it, so exceptions for > it are no longer relevant. > ... > Modified: head/share/man/man9/style.9 > ============================================================================== > --- head/share/man/man9/style.9 Tue Mar 20 21:36:35 2018 (r331268) > +++ head/share/man/man9/style.9 Tue Mar 20 21:37:33 2018 (r331269) > @@ -107,11 +107,7 @@ Only add > .Dq Li "From: " > in front of foreign VCS IDs if the file is renamed. > .Bd -literal > -#if 0 > -#ifndef lint > -static char sccsid[] = "@(#)style 1.14 (Berkeley) 4/28/95"; > -#endif /* not lint */ > -#endif > +/* From: @(#)style 1.14 (Berkeley) 4/28/95 */ This breaks the example for non-lint things in it. The description still gives the rule for adding '#if 0 ... #endif'. The example is technically partly correct, though not what is intended. The original file named 'style' doesn't have "static char sccsid[] ...". It had the sccsid in a comment, and still has it there, in the same position in the file. The char array was added to give an example of using '#if 0 ... #endif'. This change adds another copy of the comment, edited this time. This gives an example of adding "From: ". The rule says to add "From: " only if the file name changed (it should say to add it iff the file path changed and/or the current VCS doesn't have the file's history back to the version with the sccsid). This is not quite right, since the comment is duplicated, once without the editing suggested by the rule, and once with it but with the larger editing of moving the example. There is a similar self-reference problem for the FreeBSD id. $FreeBSD$ occurs twice, once in a comment and once just after the above. Duplicating it is a style bug, but there is no rule saying this so the meta-rule that style(9) gives rules by example says the opposite. Bruce