From owner-svn-src-head@FreeBSD.ORG Fri Nov 30 00:19:07 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C7943672 for ; Fri, 30 Nov 2012 00:19:07 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 337AA8FC0C for ; Fri, 30 Nov 2012 00:19:06 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id go10so54171lbb.13 for ; Thu, 29 Nov 2012 16:19:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=qb0vbC3JRACClkpqBuOk9GAmS4B5mL/+yw8QurzdulE=; b=kU6MhQq+F7etiImixSpGTbCEo3jWr/ou+er0xtFbN1GSd4P4TpwIrJRYA3ifEBIMh0 4117RGERCbEotKbDYfh+NQ6e2KOT0JT42ZJhT0BbfHzUvHPK5p2OM9sSHU3KG81yDZCX cDkYN62d0k3J+qMI/Jauc2/ZJ/eWvo9VTF6Oo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=qb0vbC3JRACClkpqBuOk9GAmS4B5mL/+yw8QurzdulE=; b=iMOyBjcblQ+bjNSt5DND3uqr+K7xVQ+7k2OIR6b9c+FtRIb41K1AAKyhask3lCCu0J MBbJ2wqe1I35FTSi5XYaLZr/aL5srQbbpkxm7i1XwvpL7ujIgE7LBqj8v2uQggYC05za Rm0gqIi7xnmRwQnuUYtJbkCR8Tqp+quPYiAuzgGrM7UuXTB2gg4OUyLOdNJsZHQMDs0H c+4zXvMsZNFu4r4Ky4qgVy42YooKmOAG0ZUmPbe9NJmKFe4ygEAPxGTQ1Q27fzK9MCJP ePScB8tx9lK7/bzLObRhRGJ9IQbgcnMfPxdPlj7lndRfcHkODPUz/OCFqbRzRpdu+/wA 7A2A== Received: by 10.152.105.103 with SMTP id gl7mr23141783lab.10.1354234746094; Thu, 29 Nov 2012 16:19:06 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.154.168 with HTTP; Thu, 29 Nov 2012 16:18:35 -0800 (PST) In-Reply-To: <20121129205729.GN3013@kib.kiev.ua> References: <201211290516.qAT5GoT5098709@svn.freebsd.org> <20121129120147.GE3013@kib.kiev.ua> <20121129162412.GD29338@stack.nl> <20121129205729.GN3013@kib.kiev.ua> From: Eitan Adler Date: Thu, 29 Nov 2012 19:18:35 -0500 X-Google-Sender-Auth: jmtyCgqPpYJmF9eXxwb0AQM0YB8 Message-ID: Subject: Re: svn commit: r243665 - head/sbin/dump To: Konstantin Belousov Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQluH6Ww7kb+uu84H4bwJgE1yV0rUBvk8z1/oDdImYNkyUungAAS6U+jJDZvrm+Je8ceejK/ Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Jilles Tjoelker X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2012 00:19:07 -0000 On 29 November 2012 15:57, Konstantin Belousov wrote: > IMO, such changes shall not be done, and the already accumulated nonsense > needs to be reverted. It causes no harm, and helps reduce the number of false positives in the clang static analyzer code so I fail to see why this should be reverted. This isn't akin to a comment as it changes the behavior of at least one helpful tool. Any future change which changed the return behavior of the function would cause an error (due to -Werror) and then the attribute could be changed. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams