Date: Thu, 29 Nov 2012 19:18:35 -0500 From: Eitan Adler <eadler@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Jilles Tjoelker <jilles@stack.nl> Subject: Re: svn commit: r243665 - head/sbin/dump Message-ID: <CAF6rxgnvON5h4dsV2pQ-uuDMMW9z6wFYTg-11z-49icZnD3pkg@mail.gmail.com> In-Reply-To: <20121129205729.GN3013@kib.kiev.ua> References: <201211290516.qAT5GoT5098709@svn.freebsd.org> <20121129120147.GE3013@kib.kiev.ua> <20121129162412.GD29338@stack.nl> <20121129205729.GN3013@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29 November 2012 15:57, Konstantin Belousov <kostikbel@gmail.com> wrote: > IMO, such changes shall not be done, and the already accumulated nonsense > needs to be reverted. It causes no harm, and helps reduce the number of false positives in the clang static analyzer code so I fail to see why this should be reverted. This isn't akin to a comment as it changes the behavior of at least one helpful tool. Any future change which changed the return behavior of the function would cause an error (due to -Werror) and then the attribute could be changed. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgnvON5h4dsV2pQ-uuDMMW9z6wFYTg-11z-49icZnD3pkg>