From owner-svn-src-projects@FreeBSD.ORG  Thu Dec 27 21:32:17 2012
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 91C83CB3;
 Thu, 27 Dec 2012 21:32:17 +0000 (UTC) (envelope-from ray@freebsd.org)
Received: from smtp.dlink.ua (smtp.dlink.ua [193.138.187.146])
 by mx1.freebsd.org (Postfix) with ESMTP id 42CBF8FC0C;
 Thu, 27 Dec 2012 21:32:16 +0000 (UTC)
Received: from rnote.ddteam.net (99-150-135-95.pool.ukrtel.net [95.135.150.99])
 (Authenticated sender: ray)
 by smtp.dlink.ua (Postfix) with ESMTPSA id 9BB58C4946;
 Thu, 27 Dec 2012 23:32:14 +0200 (EET)
Date: Thu, 27 Dec 2012 23:32:10 +0200
From: Aleksandr Rybalko <ray@freebsd.org>
To: Gavin Atkinson <gavin@FreeBSD.org>
Subject: Re: svn commit: r244668 - projects/efika_mx/sys/dev/fdt
Message-Id: <20121227233210.bc02e0d2.ray@freebsd.org>
In-Reply-To: <alpine.BSF.2.00.1212271903220.27184@thunderhorn.york.ac.uk>
References: <201212242228.qBOMSrcd093127@svn.freebsd.org>
 <alpine.BSF.2.00.1212271903220.27184@thunderhorn.york.ac.uk>
Organization: FreeBSD.ORG
X-Mailer: Sylpheed 3.1.2 (GTK+ 2.24.5; amd64-portbld-freebsd9.0)
X-Operating-System: FreeBSD
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: svn-src-projects@freebsd.org, Aleksandr Rybalko <ray@FreeBSD.org>,
 src-committers@freebsd.org
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Dec 2012 21:32:17 -0000

On Thu, 27 Dec 2012 19:06:45 +0000 (GMT)
Gavin Atkinson <gavin@FreeBSD.org> wrote:

> On Mon, 24 Dec 2012, Aleksandr Rybalko wrote:
> > Author: ray
> > Date: Mon Dec 24 22:28:52 2012
> > New Revision: 244668
> > URL: http://svnweb.freebsd.org/changeset/base/244668
> > 
> > Log:
> >   Resources can be optional, so report lack of resource only if
> > verbose. 
> >   Sponsored by:	FreeBSD Foundation
> > 
> > Modified:
> >   projects/efika_mx/sys/dev/fdt/simplebus.c
> > 
> > Modified: projects/efika_mx/sys/dev/fdt/simplebus.c
> > ==============================================================================
> > --- projects/efika_mx/sys/dev/fdt/simplebus.c	Mon Dec 24
> > 22:26:03 2012	(r244667) +++
> > projects/efika_mx/sys/dev/fdt/simplebus.c	Mon Dec 24
> > 22:28:52 2012	(r244668) @@ -259,7 +259,7 @@
> > simplebus_alloc_resource(device_t bus, d type = SYS_RES_MEMORY; 
> >  		rle = resource_list_find(&di->di_res, type, *rid);
> > -		if (rle == NULL) {
> > +		if (rle == NULL && bootverbose) {
> >  			device_printf(bus, "no default resources
> > for " "rid = %d, type = %d\n", *rid, type);
> >  			return (NULL);
> 
> This appears to be wrong to me - before the code would return(NULL) if
> rle == NULL, whereas now both rle == NULL && bootverbose must be true
> to return.  Later on, the code relies on rle being non-null, so will
> now presumably panic if !bootverbose.
> 
> Gavin

Fixed.

Thank you Gavin!

Seems commiting stuff after midnight is not good idea :)

WBW
-- 
Aleksandr Rybalko <ray@freebsd.org>