From owner-freebsd-current@FreeBSD.ORG Wed Jun 27 10:13:00 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 628C316A400 for ; Wed, 27 Jun 2007 10:13:00 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id D1DF313C45D for ; Wed, 27 Jun 2007 10:12:58 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 00A90487FA; Wed, 27 Jun 2007 12:12:56 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id C0F7B4569A; Wed, 27 Jun 2007 12:12:51 +0200 (CEST) Date: Wed, 27 Jun 2007 12:12:50 +0200 From: Pawel Jakub Dawidek To: Doug Rabson Message-ID: <20070627101249.GA1128@garage.freebsd.pl> References: <46813AF4.4020004@crc.u-strasbg.fr> <20070627070618.GC21749@garage.freebsd.pl> <200706270837.28175.dfr@rabson.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bp/iNruPH9dso1Pn" Content-Disposition: inline In-Reply-To: <200706270837.28175.dfr@rabson.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: Philippe Pegon , current@freebsd.org Subject: Re: nfs on zfs panic X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2007 10:13:00 -0000 --bp/iNruPH9dso1Pn Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 27, 2007 at 08:37:27AM +0100, Doug Rabson wrote: > On Wednesday 27 June 2007, Pawel Jakub Dawidek wrote: > > On Tue, Jun 26, 2007 at 06:10:44PM +0100, Doug Rabson wrote: > > > It looks like nvp is NULL at the point where it crashed. Looking at > > > the zfs code, zfs_vget always returns zero, even if it failed to > > > find a vnode which matches the given 'inode' number. Try changing > > > the return statement in zfs_vget from 'return (0)' to 'return > > > (err)'. > > > > Your analysis is correct, can you commit this? >=20 > I tried to commit it but got the 'need Approved by: re' message. Do you= =20 > have blanket re approval for this stuff? Nope. Could you ask re@ for approval? If you don't have time, I'll handle this later. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --bp/iNruPH9dso1Pn Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGgjghForvXbEpPzQRArbzAKCjL8q+yEJwq0JTEhJVn4fJOG00LgCgxrRs fNPLlWVY022UJ/DSnbE2BT0= =hyma -----END PGP SIGNATURE----- --bp/iNruPH9dso1Pn--