From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Nov 4 13:58:34 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5AA08796 for ; Tue, 4 Nov 2014 13:58:34 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3C946802 for ; Tue, 4 Nov 2014 13:58:34 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id sA4DwYxO021895 for ; Tue, 4 Nov 2014 13:58:34 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 194813] New: [patch] www/polipo: Cannot use a cache directory (and some fix) Date: Tue, 04 Nov 2014 13:58:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: CQG00620@nifty.ne.jp X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Nov 2014 13:58:34 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194813 Bug ID: 194813 Summary: [patch] www/polipo: Cannot use a cache directory (and some fix) Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: CQG00620@nifty.ne.jp CC: frank@pinky.sax.de CC: frank@pinky.sax.de Flags: maintainer-feedback?(frank@pinky.sax.de) Created attachment 149030 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=149030&action=edit A patch for www/polipo. (1) Cannot use a cache directory (2) Don't remove a cache directory unconditionally at uninstallation (3) Fix messages such as "pkg-static: unlinkat(usr/local/etc/polipo/): No such file or directory" at uninstallation (1) Cannot use a cache directory (Update: pkg-plist files/pkg-install.in) The owner, group and permission of a cache directory is configured by the pkg-install script: | elif [ "$2" = "POST-INSTALL" ]; then | if [ ! -d "%%DESTDIR%%$POLIPOCACHE" ]; then | mkdir -p "%%DESTDIR%%$POLIPOCACHE" || exit 1 | chown "$POLIPOUSER:$POLIPOGROUP" "%%DESTDIR%%$POLIPOCACHE" || exit 1 | chmod ug=rwx,o= "%%DESTDIR%%$POLIPOCACHE" || exit 1 | fi But the directory has already been created in Makefile. So the above commands are never executed. As a result, though the proxying works well, polipo cannot use the cache directory (because a lack of write permission). And polipo outputs a lot of error messages to /var/log/polipo like this: | Couldn't create directory /var/cache/polipo/svnweb.freebsd.org/: Permission denied To solve the problem, add appropriate arguments (owner, group, permission) to the @dir keyword in pkg-plist. (2) Don't remove a cache directory unconditionally at uninstallation (Update: files/pkg-deinstall.in) When the port is uninstalled, the cache directory is always deleted (rm -r) by pkg-deinstall even if it has cache contents. Now the directory is handled by pkg (with @dir) properly. I remove the delete routine from pkg-deinstall. (3) Fix messages such as "pkg-static: unlinkat(usr/local/etc/polipo/): No such file or directory" at uninstallation (Update: files/pkg-deinstall.in) When the port is uninstalled, some directories are deleted manually (rmdir) by pkg-deinstall. These directories are handled by pkg automatically. I remove these commands from pkg-deinstall. --- Comment #1 from Bugzilla Automation --- Maintainer CC'd -- You are receiving this mail because: You are the assignee for the bug.