From owner-freebsd-ppc@freebsd.org Thu Sep 22 21:43:02 2016 Return-Path: Delivered-To: freebsd-ppc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5C837BE59CA for ; Thu, 22 Sep 2016 21:43:02 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: from asp.reflexion.net (outbound-mail-210-56.reflexion.net [208.70.210.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 203B2A2F for ; Thu, 22 Sep 2016 21:43:01 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: (qmail 14001 invoked from network); 22 Sep 2016 17:43:51 -0000 Received: from unknown (HELO mail-cs-01.app.dca.reflexion.local) (10.81.19.1) by 0 (rfx-qmail) with SMTP; 22 Sep 2016 17:43:51 -0000 Received: by mail-cs-01.app.dca.reflexion.local (Reflexion email security v8.00.0) with SMTP; Thu, 22 Sep 2016 13:43:06 -0400 (EDT) Received: (qmail 22898 invoked from network); 22 Sep 2016 17:43:06 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with (AES256-SHA encrypted) SMTP; 22 Sep 2016 17:43:06 -0000 Received: from [192.168.0.105] (ip70-189-131-151.lv.lv.cox.net [70.189.131.151]) by iron2.pdx.net (Postfix) with ESMTPSA id D5903EC8FC3; Thu, 22 Sep 2016 10:42:59 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: From llvm: Fwd: [Bug 26519] Clang 3.8.0's "Target: powerpc-unknown-freebsd11.0" code generation is violating the SVR4 ABI (SEGV can result) [re-fixed in llvm -r282174] From: Mark Millard In-Reply-To: Date: Thu, 22 Sep 2016 10:42:58 -0700 Cc: FreeBSD Toolchain , FreeBSD PowerPC ML Content-Transfer-Encoding: quoted-printable Message-Id: References: <08136189-299F-4BD6-9E49-8D39A8913D62@dsl-only.net> <0E2783E3-277F-47F1-B696-46FCFF0DB0F1@dsl-only.net> <09E211AC-6245-4A89-94DE-225A5EBA1FD2@FreeBSD.org> <827D7E4C-5719-456E-95D3-A95BBC341E7E@dsl-only.net> To: Dimitry Andric X-Mailer: Apple Mail (2.3124) X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2016 21:43:02 -0000 Quick top post reporting that the fix for the post-amble code is in = place in llvm -r282174 : > Begin forwarded message: >=20 > From: bugzilla-daemon[ at ]llvm.org > Subject: [Bug 26519] Clang 3.8.0's "Target: = powerpc-unknown-freebsd11.0" code generation is violating the SVR4 ABI = (SEGV can result) > Date: September 22, 2016 at 10:23:21 AM PDT > To: >=20 > Krzysztof Parzyszek changed bug 26519=20 > What Removed Added > Status REOPENED RESOLVED > Resolution --- FIXED >=20 > Comment # 11 on bug 26519 from Krzysztof Parzyszek > Committed in r282174. >=20 > You are receiving this mail because: > =E2=80=A2 You reported the bug. =3D=3D=3D Mark Millard markmi at dsl-only.net On 2016-Sep-12, at 6:40 PM, Mark Millard wrote: > On 2016-Sep-10, at 6:56 PM, Mark Millard = wrote: >=20 >> Quick top post: Krzysztof has re-opened llvm bugzilla 26519 because = the post-amble side of things has not been fixed yet. . . >>=20 >>=20 >>=20 >> Krzysztof Parzyszek changed bug 26519=20 >> What Removed Added >> Status RESOLVED REOPENED >> Resolution FIXED --- >> Comment # 9 on bug 26519 from Krzysztof Parzyszek >> The post-amble has not been fixed. >>=20 >> You are receiving this mail because: >> =E2=80=A2 You reported the bug. >>=20 >> =3D=3D=3D >> Mark Millard >> markmi at dsl-only.net >=20 > There is now a code review active for this now, quoting the notice: >=20 >> Comment # 10 on bug 26519 from Krzysztof Parzyszek >> The epilogue part of the fix: https://reviews.llvm.org/D24466 >>=20 >>=20 >> Hopefully there is nothing else missing. >>=20 >> You are receiving this mail because: >> =E2=80=A2 You reported the bug. >=20 > =3D=3D=3D > Mark Millard > markmi at dsl-only.net >=20 > On 2016-Sep-10, at 6:23 PM, Mark Millard = wrote: >>=20 >> On 2016-Sep-10, at 10:18 AM, Dimitry Andric = wrote: >>=20 >>> On 06 Sep 2016, at 15:04, Mark Millard = wrote: >>>>=20 >>>> llvm's bugzilla reports that the stack-handling SVR4 ABI violation = for TARGET_ARCH=3Dpowerpc has been fixed r280705 (likely on trunk)! >>>=20 >>> I merged the upstream fix to projects/clang390-import: >>>=20 >>> https://svnweb.freebsd.org/changeset/base/305686 >>>=20 >>> -Dimitry >>=20 >> Looking at things for this again I've submitted a question to = https://llvm.org/bugs/show_bug.cgi?id=3D26519 asking if the post-amble = code's side if things was also adjusted (instead of just the = pre-amble/"claim" code side of things). >>=20 >> [I'm not clang/llvm literate so I may have missed interpreted = something when I looked.] >>=20 >> My original submittal also noted the stack pointer adjustment-timing = problem existed on the post-amble side in 3.8.0's code generation (when = removing the frame from the stack): >>=20 >>> 0x1801b8c : lwz r30,24(r31) >>> 0x1801b90 : lwz r29,20(r31) >>> 0x1801b94 : lwz r28,16(r31) >>> 0x1801b98 : lwz r27,12(r31) >>> 0x1801b9c : lwz r26,8(r31) >>> 0x1801ba0 : addi r1,r1,32 # Stack = pointer adjusted first >>> 0x1801ba4 : lwz r0,4(r1) >>> 0x1801ba8 : lwz r31,-4(r1) # Then Frame = Pointer load happens >>> # "outside" the new = stack range. >>> 0x1801bac : mtlr r0 >>> 0x1801bb0 : blr >>=20 >> If such code can still be generated there would still be a time frame = needing a red-zone to protect stack the contents from signals. >>=20 >> Hopefully I'm just wrong and this was fixed too. >>=20 >>=20 >>=20 >> =3D=3D=3D >> Mark Millard >> markmi at dsl-only.net >>=20 >>=20 >=20