From owner-cvs-src@FreeBSD.ORG Thu Jun 5 08:33:25 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C6C7337B430 for ; Thu, 5 Jun 2003 08:33:22 -0700 (PDT) Received: from mail.speakeasy.net (mail15.speakeasy.net [216.254.0.215]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0643943F85 for ; Thu, 5 Jun 2003 08:33:18 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 24968 invoked from network); 5 Jun 2003 15:33:17 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 5 Jun 2003 15:33:17 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h55FXFp0010798; Thu, 5 Jun 2003 11:33:15 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030605100007.GA42986@sunbay.com> Date: Thu, 05 Jun 2003 11:33:16 -0400 (EDT) From: John Baldwin To: Ruslan Ermilov cc: Marcel Moolenaar cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jun 2003 15:33:25 -0000 On 05-Jun-2003 Ruslan Ermilov wrote: > On Tue, Jun 03, 2003 at 10:17:18PM -0700, Marcel Moolenaar wrote: >> marcel 2003/06/03 22:17:18 PDT >> >> FreeBSD src repository >> >> Modified files: >> release Makefile >> Log: >> Have the port readmes follow the same logic as buildworld. We skip >> doing make readmes if /tmp/.skip_ports exists. This file is created >> after a complete run, which avoids that we do the lengthy operation >> again for a rerelease. >> When NOPORTS or NOPORTREADMES are defined, we create the file prior >> to starting the release. >> >> Revision Changes Path >> 1.781 +5 -5 src/release/Makefile >> > I think this is not quite right. Instead, the /tmp/.ports_done > should be created, similar to /tmp/.world_done, when ports are > really done. > > When NOPORTS or NOPORTREADMES are defined, we should just not be > doing the relevant parts of "make release". And of course, it > should be possible to run "make -DNOPORTS release" first, and be > able to run "make rerelease" later, and get the ports built. > > What do you think? I agree. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/