From owner-cvs-all@FreeBSD.ORG Tue Apr 3 01:49:24 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 03A7616A402; Tue, 3 Apr 2007 01:49:24 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from smtpout.mac.com (smtpout.mac.com [17.250.248.184]) by mx1.freebsd.org (Postfix) with ESMTP id D944A13C48A; Tue, 3 Apr 2007 01:49:21 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from mac.com (smtpin04-en2 [10.13.10.149]) by smtpout.mac.com (Xserve/smtpout14/MantshX 4.0) with ESMTP id l331nLfa023793; Mon, 2 Apr 2007 18:49:21 -0700 (PDT) Received: from [192.168.1.3] (c-24-6-177-228.hsd1.ca.comcast.net [24.6.177.228]) (authenticated bits=0) by mac.com (Xserve/smtpin04/MantshX 4.0) with ESMTP id l331nEAM015828 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 2 Apr 2007 18:49:18 -0700 (PDT) In-Reply-To: <20070403012527.GH19923@wantadilla.lemis.com> References: <200704022132.l32LWjwt084642@repoman.freebsd.org> <20070403012527.GH19923@wantadilla.lemis.com> Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <1F21AA9B-4D6B-4C67-BF6B-ED63B7E7EB14@mac.com> Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Mon, 2 Apr 2007 18:48:27 -0700 To: "Greg 'groggy' Lehey" X-Mailer: Apple Mail (2.752.3) X-Brightmail-Tracker: AAAAAA== X-Brightmail-scanned: yes Cc: cvs-src@FreeBSD.org, Marcel Moolenaar , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2007 01:49:24 -0000 On Apr 2, 2007, at 6:25 PM, Greg 'groggy' Lehey wrote: > On Monday, 2 April 2007 at 21:32:44 +0000, Marcel Moolenaar wrote: >> marcel 2007-04-02 21:32:44 UTC >> >> FreeBSD src repository >> >> Modified files: >> . Makefile >> Log: >> Introduce a variable TARGETS that can be set on the make command >> line > > This sounded excellent until I read on. > >> and that controls which platforms are being built as part of a >> "make universe". > > That's not quite what I had expected with a variable called TARGETS. > Wouldn't PLATFORMS be more "intuitive"? Maybe. I chose TARGETS because the loop in question was: .for target in amd64 arm i386 ... Also, TARGETS is in line with TARGET and/or TARGET_ARCH, which relate closely to MACHINE and MACHINE_ARCH. It seems a good choice to me... I don't mind if people change it to a different name, whether more intuitive to promote its use or less intuitive to limit/demote its use. I just like having the functionality because it allows me to use make universe more often :-) -- Marcel Moolenaar xcllnt@mac.com