From owner-cvs-all@FreeBSD.ORG Tue Apr 25 19:40:12 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AAA7616A400; Tue, 25 Apr 2006 19:40:12 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1D7A543D62; Tue, 25 Apr 2006 19:40:08 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k3PJe66P063098; Tue, 25 Apr 2006 15:40:08 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Scott Long Date: Tue, 25 Apr 2006 15:39:57 -0400 User-Agent: KMail/1.9.1 References: <200604251918.k3PJImQA007820@repoman.freebsd.org> <444E7750.206@samsco.org> In-Reply-To: <444E7750.206@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200604251540.00170.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1425/Tue Apr 25 08:09:41 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.1 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/bce if_bcereg.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2006 19:40:12 -0000 On Tuesday 25 April 2006 15:24, Scott Long wrote: > John Baldwin wrote: > > jhb 2006-04-25 19:18:48 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/bce if_bcereg.h > > Log: > > Fix half of the current i386 tinderbox failure. max_bus_addr should be a > > bus_addr_t rather than a bus_size_t. > > > > Revision Changes Path > > 1.2 +1 -1 src/sys/dev/bce/if_bcereg.h > > Actually, bus_size_t should also be aware of PAE. That may be true as well, I'll defer to your judgement on that one. In this case bus_dma_tag_create()'s low_addr argument is supposed to be a bus_addr_t according to the man page. :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org