From owner-freebsd-current@FreeBSD.ORG Thu Aug 24 19:38:43 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 09BD916A4DE for ; Thu, 24 Aug 2006 19:38:43 +0000 (UTC) (envelope-from oleg@lath.rinet.ru) Received: from lath.rinet.ru (lath.rinet.ru [195.54.192.90]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D3D743D49 for ; Thu, 24 Aug 2006 19:38:41 +0000 (GMT) (envelope-from oleg@lath.rinet.ru) Received: from lath.rinet.ru (localhost [127.0.0.1]) by lath.rinet.ru (8.13.6/8.13.6) with ESMTP id k7OJceRE039995 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 24 Aug 2006 23:38:40 +0400 (MSD) (envelope-from oleg@lath.rinet.ru) Received: (from oleg@localhost) by lath.rinet.ru (8.13.6/8.13.6/Submit) id k7OJce7q039994; Thu, 24 Aug 2006 23:38:40 +0400 (MSD) (envelope-from oleg) Date: Thu, 24 Aug 2006 23:38:40 +0400 From: Oleg Bulyzhin To: Pyun YongHyeon Message-ID: <20060824193840.GC39797@lath.rinet.ru> References: <20060822073201.GI12848@cdnetworks.co.kr> <20060822144341.L5561@fw.reifenberger.com> <20060822204342.GA4943@lath.rinet.ru> <20060823005554.GC17902@cdnetworks.co.kr> <20060823124035.GA18628@lath.rinet.ru> <20060823125434.GA19111@lath.rinet.ru> <20060824003035.GB22634@cdnetworks.co.kr> <20060824004354.GC25876@lath.rinet.ru> <20060824010746.GC22634@cdnetworks.co.kr> <20060824011244.GB27699@lath.rinet.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060824011244.GB27699@lath.rinet.ru> User-Agent: Mutt/1.5.11 Cc: Michael Reifenberger , freebsd-current@freebsd.org Subject: Re: call for bge(4) testers X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2006 19:38:43 -0000 On Thu, Aug 24, 2006 at 05:12:44AM +0400, Oleg Bulyzhin wrote: > On Thu, Aug 24, 2006 at 10:07:46AM +0900, Pyun YongHyeon wrote: > > > > I can't remember what caused this. Need more coffee. :-( > > If my memory serve me right it's related with ioctls. > > I guess you can easily experiment with removing MTX_RECURSE flag > > in the driver. > > I'll try tomorrow (oh, today), have to sleep a bit. :) I've used bge(4) today with WITNESS enabled. Yes, i've got panic about 'recursion on non-recursive mutex' when i tried to issue 'ifconfig bge0 up' command. Though it was easy to fix it. (look at if_bge.c rev. 1.140). bge(4) is somewhat special cause it can handle TBI cards. (it is using bge_ifmedia_upd() inside bge_init_locked, thus i've added bge_ifmedia_upd_locked() in order to avoid mutex recursion). vge(4) (which is copper only, i.e. pure miibus(4) driver) is using mii_mediachg() inside vge_init(), so ifmedia callbacks can be locked 'as is'. Am i mistaken somewhere? -- Oleg.