Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 24 Aug 2006 23:38:40 +0400
From:      Oleg Bulyzhin <oleg@freebsd.org>
To:        Pyun YongHyeon <pyunyh@gmail.com>
Cc:        Michael Reifenberger <mike@Reifenberger.com>, freebsd-current@freebsd.org
Subject:   Re: call for bge(4) testers
Message-ID:  <20060824193840.GC39797@lath.rinet.ru>
In-Reply-To: <20060824011244.GB27699@lath.rinet.ru>
References:  <20060822073201.GI12848@cdnetworks.co.kr> <20060822144341.L5561@fw.reifenberger.com> <20060822204342.GA4943@lath.rinet.ru> <20060823005554.GC17902@cdnetworks.co.kr> <20060823124035.GA18628@lath.rinet.ru> <20060823125434.GA19111@lath.rinet.ru> <20060824003035.GB22634@cdnetworks.co.kr> <20060824004354.GC25876@lath.rinet.ru> <20060824010746.GC22634@cdnetworks.co.kr> <20060824011244.GB27699@lath.rinet.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 24, 2006 at 05:12:44AM +0400, Oleg Bulyzhin wrote:
> On Thu, Aug 24, 2006 at 10:07:46AM +0900, Pyun YongHyeon wrote:
> > 
> > I can't remember what caused this. Need more coffee. :-(
> > If my memory serve me right it's related with ioctls.
> > I guess you can easily experiment with removing MTX_RECURSE flag
> > in the driver.
> 
> I'll try tomorrow (oh, today), have to sleep a bit. :)

I've used  bge(4) today with WITNESS enabled. Yes, i've got panic about
'recursion on non-recursive mutex' when i tried to issue 'ifconfig bge0 up'
command.
Though it was easy to fix it. (look at if_bge.c rev. 1.140).

bge(4) is somewhat special cause it can handle TBI cards.
(it is using bge_ifmedia_upd() inside bge_init_locked, thus i've added
bge_ifmedia_upd_locked() in order to avoid mutex recursion).

vge(4) (which is copper only, i.e. pure miibus(4) driver) is using 
mii_mediachg() inside vge_init(), so ifmedia callbacks can be locked 'as is'.

Am i mistaken somewhere?

-- 
Oleg.




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060824193840.GC39797>