Date: Thu, 27 May 2021 15:20:51 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 256201] sysutils/fusefs-ntfs: delete obsolete patch to lowntfs-3g.c Message-ID: <bug-256201-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256201 Bug ID: 256201 Summary: sysutils/fusefs-ntfs: delete obsolete patch to lowntfs-3g.c Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: asomers@FreeBSD.org CC: freebsd@dussan.org Flags: maintainer-feedback?(freebsd@dussan.org) CC: freebsd@dussan.org Created attachment 225320 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D225320&action= =3Dedit Delete an obsolete patch. sysutils/fusefs-ntfs patches src/lowntfs-3g.c to remove the return action f= rom ntfs_fuse_bmap. But that function cannot possibly work correctly in the patched form. It _must_ call either fuse_reply_err or fuse_reply_bmap, or = else the fusefs driver will leak commands and user threads will hang. This patch was added in 2010, so I'm guessing that ports' copy of libfuse in 2010 lack= ed bmap support. That would explain the necessity of the patch. However, it serves no purpose now, and can be deleted. I have build tested this in Poudriere for amd64 13.0, 12.2, and 11.4. But I haven't done any runtime testing. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-256201-7788>