From owner-freebsd-java@FreeBSD.ORG Thu Oct 9 07:01:47 2003 Return-Path: Delivered-To: freebsd-java@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF64C16A4C0 for ; Thu, 9 Oct 2003 07:01:47 -0700 (PDT) Received: from mgr4.xmission.com (mgr4.xmission.com [198.60.22.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F82143FA3 for ; Thu, 9 Oct 2003 07:01:44 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) Received: from mail by mgr4.xmission.com with spam-scanned (Exim 3.35 #1) id 1A7bMN-0002i8-04 for freebsd-java@freebsd.org; Thu, 09 Oct 2003 08:01:43 -0600 Received: from [207.135.128.145] (helo=misty.eyesbeyond.com) by mgr4.xmission.com with esmtp (Exim 3.35 #1) id 1A7bMI-0002gi-04; Thu, 09 Oct 2003 08:01:39 -0600 Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1]) h99E1ujG095855; Thu, 9 Oct 2003 08:02:14 -0600 (MDT) (envelope-from glewis@eyesbeyond.com) Received: (from glewis@localhost) by misty.eyesbeyond.com (8.12.9p1/8.12.9/Submit) id h99E1TtJ095846; Thu, 9 Oct 2003 08:01:29 -0600 (MDT) X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to glewis@eyesbeyond.com using -f Date: Thu, 9 Oct 2003 08:01:22 -0600 From: Greg Lewis To: Munehiro Matsuda Message-ID: <20031009140122.GA95791@misty.eyesbeyond.com> References: <20031009005113.GA50130@misty.eyesbeyond.com> <20031009.182515.74753005.haro@kgt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031009.182515.74753005.haro@kgt.co.jp> User-Agent: Mutt/1.4.1i X-Spam-Checker-Version: SpamAssassin 2.60 (1.212-2003-09-23-exp) on mgr4.xmission.com X-Spam-Status: No, hits=-0.9 required=8.0 tests=BAYES_30,UPPERCASE_25_50 autolearn=no version=2.60 X-Spam-Level: cc: phantom@freebsd.org cc: freebsd-java@freebsd.org Subject: Re: jdk14 patches X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Oct 2003 14:01:47 -0000 Hi Haro-san, On Thu, Oct 09, 2003 at 06:25:15PM +0900, Munehiro Matsuda wrote: > Good work, as always. :-) > > But grancing through your patches, I'm not sure I like the > following part, which tries to work around the '_LITTLE_ENDIAN' > problem. This change may hide other errors, that may cause > more trouble in the future. I agree. I don't intend to commit this patch to the project repository, but it was the simplest patch to get people going with the port. > I use the following patch myself. I don't like my patch, neither. ;-) > But better show errors, than hide them away. > > ---8<------8<------8<--- patch-zharo-common::Defs-bsd.gmk ---8<------8<---- > --- ../../j2se/make/common/Defs-bsd.gmk.org Wed Oct 8 09:31:35 2003 > +++ ../../j2se/make/common/Defs-bsd.gmk Mon Oct 6 20:33:00 2003 > @@ -277,7 +277,13 @@ > CXXFLAGS_DBG = -g > > CPPFLAGS_COMMON = -D$(ARCH) -DARCH='"$(ARCH)"' $(VERSION_DEFINES) \ > - -D_GNU_SOURCE -D_REENTRANT -D_THREAD_SAFE -D_LITTLE_ENDIAN > + -D_GNU_SOURCE -D_REENTRANT -D_THREAD_SAFE > + > +ifeq ($(TRUE_PLATFORM), FreeBSD) > +CPPFLAGS_COMMON += -D_LITTLE_ENDIAN=1234 > +else > +CPPFLAGS_COMMON += -D_LITTLE_ENDIAN > +endif > > ifeq ($(ARCH_DATA_MODEL), 64) > CPPFLAGS_COMMON += -D_LP64=1 I have a different patch I was intending to commit. It removes the setting of -D_LITTLE_ENDIAN at all and uses to replace its usage in the appropriate files. That is what ended up being done in 1.3, so I was just going to do the same in 1.4 (Alexey asked me to hold off until after patchset 4 though). Comments? -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org