From owner-svn-ports-all@FreeBSD.ORG Tue Sep 16 00:13:53 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 64FCA8A6; Tue, 16 Sep 2014 00:13:53 +0000 (UTC) Received: from mail-vc0-x22f.google.com (mail-vc0-x22f.google.com [IPv6:2607:f8b0:400c:c03::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E22FA692; Tue, 16 Sep 2014 00:13:52 +0000 (UTC) Received: by mail-vc0-f175.google.com with SMTP id hq11so4213270vcb.34 for ; Mon, 15 Sep 2014 17:13:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=n746p/AlTW9uXpLz7ZMxd7rQxWqT40EZOSusAbTVQdg=; b=eMvv/bwp0eC2jablVnGDJsocAqsetZjW6qRjthkfr+wCwSn1EJyECztJa2r1pc9Kvf w1yu+Fi96csGzxmh3ARDdmwtMahORVAd9rXbJ6GW5MVYxt4w1KWDA+SN3p7ALtQiI5NV dfU66vNAGZyK8D/TwZXIpnHeCpGQCh7od/FR/39au9LlKfLUKbfrC53z75BfsodYbxpm 0I4RMvr+BHKq4VDX4+Af/VXOhZ3vNjGsxABV73ahJORVd547m/tgsFR6WunxtOIQO+Jh a0bCaGpwWNwfN9sMLazHW8+VkkY/236PbKYzHRRhnzfQi7WsKS2/PRuoL5As6f6iy9+b tIGw== MIME-Version: 1.0 X-Received: by 10.220.99.71 with SMTP id t7mr25508586vcn.8.1410826431559; Mon, 15 Sep 2014 17:13:51 -0700 (PDT) Sender: bsdkaffee@gmail.com Received: by 10.220.153.19 with HTTP; Mon, 15 Sep 2014 17:13:51 -0700 (PDT) In-Reply-To: <201409151453.s8FErDCV032464@svn.freebsd.org> References: <201409151453.s8FErDCV032464@svn.freebsd.org> Date: Mon, 15 Sep 2014 20:13:51 -0400 X-Google-Sender-Auth: mYMmubF5Hg4Jf9IuireC1v3oZMI Message-ID: Subject: Re: svn commit: r368267 - head/math/gotoblas From: "Jason E. Hale" To: Thomas Zander Content-Type: text/plain; charset=UTF-8 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , ports-committers X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Sep 2014 00:13:53 -0000 On Mon, Sep 15, 2014 at 10:53 AM, Thomas Zander wrote: > Author: riggs > Date: Mon Sep 15 14:53:12 2014 > New Revision: 368267 > URL: http://svnweb.freebsd.org/changeset/ports/368267 > QAT: https://qat.redports.org/buildarchive/r368267/ > > Log: > - Use DYNAMIC_ARCH on i386 and amd64 by default > - Bump PORTREVISION > > PR: 161359 > Submitted by: phd_kimberlite@yahoo.co.jp > Patch by: cpm@fbsd.es (maintainer) > > Modified: > head/math/gotoblas/Makefile > > Modified: head/math/gotoblas/Makefile > ============================================================================== > --- head/math/gotoblas/Makefile Mon Sep 15 14:51:35 2014 (r368266) > +++ head/math/gotoblas/Makefile Mon Sep 15 14:53:12 2014 (r368267) > @@ -3,7 +3,7 @@ > > PORTNAME= gotoblas > PORTVERSION= 2.${GOTOBLAS2VER}.${LAPACKVER} > -PORTREVISION= 4 > +PORTREVISION= 5 > CATEGORIES= math > MASTER_SITES= ${MASTER_SITE_LOCAL:S|%SUBDIR%|maho/gotoblas|} \ > NL:lapack,lapack_tmg > @@ -39,11 +39,6 @@ SUB_FILES= pkg-message > SUB_LIST= MAXTHREADS=${MAXTHREADS} > MAKE_JOBS_UNSAFE= yes > > -.if defined(PACKAGE_BUILDING) > -OPTIONS_DEFAULT_i386= DYNAMIC_ARCH > -OPTIONS_DEFAULT_amd64= DYNAMIC_ARCH > -.endif > - > OPTIONS_DEFINE_i386= DYNAMIC_ARCH > OPTIONS_DEFINE_amd64= DYNAMIC_ARCH > OPTIONS_DEFINE= INTERFACE64 OPENMP > @@ -54,6 +49,12 @@ OPENMP_DESC= Use OpenMP for threading > > .include > > +.if ${ARCH} == "i386" > +OPTIONS_DEFAULT_i386= DYNAMIC_ARCH > +.elif ${ARCH} == "amd64" > +OPTIONS_DEFAULT_amd64= DYNAMIC_ARCH > +.endif > + > MAXTHREADS?= 8 > > .if ${ARCH:M*64} == "" > I think wrapping OPTIONS_DEFAULT_${ARCH} with ${ARCH} defeats the purpose of having OPTIONS_DEFAULT_${ARCH} in the first place. Wouldn't simply removing .if defined(PACKAGE_BUILDING)/.endif have been enough?