From owner-freebsd-current@FreeBSD.ORG Wed Mar 31 12:58:07 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0A55216A4DC for ; Wed, 31 Mar 2004 12:58:06 -0800 (PST) Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F25743D1D for ; Wed, 31 Mar 2004 12:58:06 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 31882 invoked from network); 31 Mar 2004 20:58:05 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 31 Mar 2004 20:58:05 -0000 Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i2VKsMDR048661; Wed, 31 Mar 2004 15:57:51 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Scott Long Date: Wed, 31 Mar 2004 15:45:39 -0500 User-Agent: KMail/1.6 References: <20040328211018.GN3446@dan.emsphone.com> <20040328222031.GA19463@dan.emsphone.com> <40675694.3080609@freebsd.org> In-Reply-To: <40675694.3080609@freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200403311545.39264.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: freebsd-current@freebsd.org cc: Dan Nelson Subject: Re: panic: mutex Giant owned at ../../../kern/kern_thread.c:1341 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2004 20:58:07 -0000 On Sunday 28 March 2004 05:49 pm, Scott Long wrote: > Dan Nelson wrote: > > In the last episode (Mar 28), Dan Nelson said: > >>Got this running an ibcs2_coff binary on today's kernel: > >> > >>(kgdb) where > >>#6 0xc7c1dd5b in ibcs2_wait (td=0xc7ef5540, uap=0x0) > >> at /usr/src/sys/i386/ibcs2/ibcs2_misc.c:164 > > > > I think this is due to ibcs2_wait being left out when wait4() was > > converted to giant-free (giant-allergic actually). The following seems > > to fix it: > > > > Index: syscalls.master > > =================================================================== > > RCS file: /mnt/emssrv5/home/ncvs/src/sys/i386/ibcs2/syscalls.master,v > > retrieving revision 1.17 > > diff -u -r1.17 syscalls.master > > --- syscalls.master 6 Feb 2004 20:20:07 -0000 1.17 > > +++ syscalls.master 28 Mar 2004 22:00:40 -0000 > > @@ -37,7 +37,7 @@ > > 4 MNOPROTO { int write(int fd, char *buf, u_int nbytes); } > > 5 STD { int ibcs2_open(char *path, int flags, int mode); } > > 6 MNOPROTO { int close(int fd); } > > -7 STD { int ibcs2_wait(int a1, int a2, int a3); } > > +7 MSTD { int ibcs2_wait(int a1, int a2, int a3); } > > 8 STD { int ibcs2_creat(char *path, int mode); } > > 9 NOPROTO { int link(char *path, char *link); } > > 10 STD { int ibcs2_unlink(char *path); } > > I agree that this is appropriate. However, ibcs2_wait() might need to > have some proc locks sprinkled into it. It would be good to have > someone like John Baldwin comment on it. It's safe, I just forgot to tag it along with the other wait functions when I added kern_wait() it seems. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org